From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavfi/dnn: Fix OpenVINO missing model file corrupt issue.
Date: Sat, 06 Aug 2022 14:57:19 +0200
Message-ID: <165979063965.3205.4894546530766037463@lain.khirnov.net> (raw)
In-Reply-To: =?utf-8?q?=3CSN6PR11MB3117D33F2B10072509FAF7C7E69E9=40SN6PR11MB?= =?utf-8?q?3117=2Enamprd11=2Eprod=2Eoutlook=2Ecom=3E?=
Quoting Fu, Ting (2022-08-05 05:34:30)
> Hi Anton,
>
> Thank you for comment.
> After double checked the OpenVINO, it is true that the code would corrupt if the binary file does not exist.
Can you be more specific about what do you mean by "corrupt"?
> We would have nothing to do in this case, that's why I code to check the file existence explicitly.
> Yes, you are right, it is not a proper way to do like this. But I have no idea how to solve it more decently, since trying to open it as you mentioned would lead to crush immediately. Maybe there is some solution I don’t know, any further input would be appreciated. 😊
It should be fixed in OpenVINO, and we should disallow any older
versions from being used in lavfi. Your patch is still susceptible to
someone removing the file after the access() call.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-06 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:31 Ting Fu
2022-08-04 10:39 ` Anton Khirnov
2022-08-05 3:34 ` Fu, Ting
2022-08-06 12:57 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165979063965.3205.4894546530766037463@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git