From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 02489439BE for ; Thu, 4 Aug 2022 10:40:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BFAFC68B992; Thu, 4 Aug 2022 13:39:58 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BC0268B93A for ; Thu, 4 Aug 2022 13:39:52 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 975EC240179 for ; Thu, 4 Aug 2022 12:39:51 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id lQ9if5uBX2Zd for ; Thu, 4 Aug 2022 12:39:50 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 47FEA2400F5 for ; Thu, 4 Aug 2022 12:39:50 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 70FFC1601B2; Thu, 4 Aug 2022 12:39:50 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220804093101.30059-1-ting.fu@intel.com> References: <20220804093101.30059-1-ting.fu@intel.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 04 Aug 2022 12:39:50 +0200 Message-ID: <165960959043.10012.12775097914782843053@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavfi/dnn: Fix OpenVINO missing model file corrupt issue. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Ting Fu (2022-08-04 11:31:01) > DNN OpenVINO backend would not report missing model file if it does not > exist. It would corrupt directly with out any error infomation. This commit "corrupt"? The patch looks completely wrong. Testing for file existence explicitly is known to be a bad pattern that leads to all kinds of races, security issues, and other bugs. Just trying to open the file and returning an error if that fails is the right thing to do. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".