Re: [FFmpeg-devel] [PATCH v3 1/2] ffmpeg: refactor post-decoding steps for subtitles into a function

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] ffmpeg: refactor post-decoding steps for subtitles into a function
Date: Tue, 02 Aug 2022 15:15:32 +0200
Message-ID: <165944613294.15471.17295970588728726323@lain.khirnov.net> (raw)
In-Reply-To: <20220729133537.53269-1-jeebjp@gmail.com>

Quoting Jan Ekström (2022-07-29 15:35:36)
> From: Jan Ekström <jan.ekstrom@24i.com>
> 
> This enables us to later call this when generating additional
> subtitles for splitting purposes.
> 
> Co-authored-by: Andrzej Nadachowski <andrzej.nadachowski@24i.com>
> 
> Signed-off-by: Jan Ekström <jan.ekstrom@24i.com>
> ---
>  fftools/ffmpeg.c | 50 ++++++++++++++++++++++++++++--------------------
>  1 file changed, 29 insertions(+), 21 deletions(-)
> 
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 4746742c02..adcab43a30 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -2301,27 +2301,16 @@ fail:
>      return err < 0 ? err : ret;
>  }
>  
> -static int transcode_subtitles(InputStream *ist, AVPacket *pkt, int *got_output,
> -                               int *decode_failed)
> +static int encode_mux_subtitles(InputStream *ist, AVSubtitle *subtitle, int *got_output)

A function called 'encode_mux' should not be doing anything with an
input stream.

I also think this will spurisouly increment ist->frames_decoded after
the second patch.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".