From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3D8864388E for ; Tue, 2 Aug 2022 11:13:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 896ED68BAB4; Tue, 2 Aug 2022 14:13:25 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 503F368B8DD for ; Tue, 2 Aug 2022 14:13:19 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B9525240179 for ; Tue, 2 Aug 2022 13:13:18 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id B4UixtFdTJ8q for ; Tue, 2 Aug 2022 13:13:18 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 576152400F5 for ; Tue, 2 Aug 2022 13:13:18 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 943FA1601B2; Tue, 2 Aug 2022 13:13:18 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220728172247.2092-1-jamrial@gmail.com> References: <20220728172247.2092-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 02 Aug 2022 13:13:18 +0200 Message-ID: <165943879857.15471.15965932994591726887@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: print a log message when treating mono HE-AAC as stereo X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2022-07-28 19:22:47) > Since this behavior is intentional, use the VERBOSE level instead of WARNING as > it's nothing the user should worry about. > > Signed-off-by: James Almer > --- > libavcodec/aac.h | 1 + > libavcodec/aacdec_template.c | 4 ++++ > libavcodec/aacsbr_template.c | 2 ++ > 3 files changed, 7 insertions(+) > > diff --git a/libavcodec/aac.h b/libavcodec/aac.h > index 53be546857..c8d6b17710 100644 > --- a/libavcodec/aac.h > +++ b/libavcodec/aac.h > @@ -366,6 +366,7 @@ struct AACContext { > int warned_960_sbr; > unsigned warned_71_wide; > int warned_gain_control; > + int warned_he_aac_mono; I now count 6 warned_foo vars in the context, which is quite wasteful. We might want to change those into flags. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".