From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: print a log message when treating mono HE-AAC as stereo
Date: Tue, 02 Aug 2022 13:13:18 +0200
Message-ID: <165943879857.15471.15965932994591726887@lain.khirnov.net> (raw)
In-Reply-To: <20220728172247.2092-1-jamrial@gmail.com>
Quoting James Almer (2022-07-28 19:22:47)
> Since this behavior is intentional, use the VERBOSE level instead of WARNING as
> it's nothing the user should worry about.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavcodec/aac.h | 1 +
> libavcodec/aacdec_template.c | 4 ++++
> libavcodec/aacsbr_template.c | 2 ++
> 3 files changed, 7 insertions(+)
>
> diff --git a/libavcodec/aac.h b/libavcodec/aac.h
> index 53be546857..c8d6b17710 100644
> --- a/libavcodec/aac.h
> +++ b/libavcodec/aac.h
> @@ -366,6 +366,7 @@ struct AACContext {
> int warned_960_sbr;
> unsigned warned_71_wide;
> int warned_gain_control;
> + int warned_he_aac_mono;
I now count 6 warned_foo vars in the context, which is quite wasteful.
We might want to change those into flags.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-02 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 17:22 James Almer
2022-08-02 11:13 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165943879857.15471.15965932994591726887@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git