[FFmpeg-devel] [PATCH] avdevice/v4l2: fix leak of timefilter

[FFmpeg-devel] [PATCH] avdevice/v4l2: fix leak of timefilter

[Zhao Zhili]

From: Zhao Zhili <zhilizhao@tencent.com>

Fixes ticket #9844.
---
I don't have a camera for test. So I'm not sure if it's the only case
of memleak in ticket #9844.

 libavdevice/v4l2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
index 5340382d57..be422d7c8c 100644
--- a/libavdevice/v4l2.c
+++ b/libavdevice/v4l2.c
@@ -1011,6 +1011,7 @@ static int v4l2_read_close(AVFormatContext *ctx)
 
     mmap_close(s);
 
+    ff_timefilter_destroy(s->timefilter);
     v4l2_close(s->fd);
     return 0;
 }
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: fix leak of timefilter

[Anton Khirnov]

Quoting Zhao Zhili (2022-07-26 18:32:51)
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> Fixes ticket #9844.
> ---
> I don't have a camera for test. So I'm not sure if it's the only case
> of memleak in ticket #9844.
> 
>  libavdevice/v4l2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c
> index 5340382d57..be422d7c8c 100644
> --- a/libavdevice/v4l2.c
> +++ b/libavdevice/v4l2.c
> @@ -1011,6 +1011,7 @@ static int v4l2_read_close(AVFormatContext *ctx)
>  
>      mmap_close(s);
>  
> +    ff_timefilter_destroy(s->timefilter);

Tested, works, LGTM

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".