From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D1EAB43886 for ; Tue, 2 Aug 2022 11:10:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 33C2D68BAB1; Tue, 2 Aug 2022 14:10:27 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D8A7168B650 for ; Tue, 2 Aug 2022 14:10:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 62BF4240179; Tue, 2 Aug 2022 13:10:20 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 2WaS9V6bEizL; Tue, 2 Aug 2022 13:10:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E556A2400F5; Tue, 2 Aug 2022 13:10:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 25B5E1601B2; Tue, 2 Aug 2022 13:10:20 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches , Zhao Zhili Date: Tue, 02 Aug 2022 13:10:20 +0200 Message-ID: <165943862012.15471.5319022979639248647@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: fix leak of timefilter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Zhao Zhili (2022-07-26 18:32:51) > From: Zhao Zhili > > Fixes ticket #9844. > --- > I don't have a camera for test. So I'm not sure if it's the only case > of memleak in ticket #9844. > > libavdevice/v4l2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c > index 5340382d57..be422d7c8c 100644 > --- a/libavdevice/v4l2.c > +++ b/libavdevice/v4l2.c > @@ -1011,6 +1011,7 @@ static int v4l2_read_close(AVFormatContext *ctx) > > mmap_close(s); > > + ff_timefilter_destroy(s->timefilter); Tested, works, LGTM -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".