From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 78D0A4387B for ; Tue, 2 Aug 2022 09:30:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D8CDC68BA4A; Tue, 2 Aug 2022 12:30:47 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5761468B804 for ; Tue, 2 Aug 2022 12:30:41 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A64B6240179 for ; Tue, 2 Aug 2022 11:30:40 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id IJcowfotNpMD for ; Tue, 2 Aug 2022 11:30:40 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 040192400F5 for ; Tue, 2 Aug 2022 11:30:40 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3C9A71601B2; Tue, 2 Aug 2022 11:30:39 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220730171239.GE2088045@pb2> References: =?utf-8?q?=3CDB6PR0101MB22140CEE765FDFAB596653698F949=40DB6PR010?= =?utf-8?q?1MB2214=2Eeurprd01=2Eprod=2Eexchangelabs=2Ecom=3E_=3CDB6PR0101MB2?= =?utf-8?q?214194F1E9DCC5074799DC28F949=40DB6PR0101MB2214=2Eeurprd01=2Eprod?= =?utf-8?q?=2Eexchangelabs=2Ecom=3E_=3C20220728220540=2EGC2088045=40pb2=3E_?= =?utf-8?q?=3CDB6PR0101MB2214EF6DD8DB952007683D248F989=40DB6PR0101MB2214=2Ee?= =?utf-8?q?urprd01=2Eprod=2Eexchangelabs=2Ecom=3E?= <20220730171239.GE2088045@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 02 Aug 2022 11:30:39 +0200 Message-ID: <165943263921.15471.1512917784463747668@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 34/39] avcodec/mpegvideoencdsp: Allow pointers to const where possible X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2022-07-30 19:12:39) > On Sat, Jul 30, 2022 at 11:55:45AM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > On Wed, Jul 27, 2022 at 12:08:09AM +0200, Andreas Rheinhardt wrote: > > >> Signed-off-by: Andreas Rheinhardt > > >> --- > > >> libavcodec/arm/mpegvideoencdsp_init_arm.c | 4 ++-- > > >> libavcodec/mips/h263dsp_mips.h | 2 +- > > >> libavcodec/mips/mpegvideoencdsp_msa.c | 4 ++-- > > >> libavcodec/mpegvideoencdsp.c | 10 +++++----- > > >> libavcodec/mpegvideoencdsp.h | 10 +++++----- > > >> libavcodec/ppc/mpegvideoencdsp.c | 8 ++++---- > > >> libavcodec/x86/mpegvideoenc_qns_template.c | 4 ++-- > > >> libavcodec/x86/mpegvideoencdsp.asm | 4 ++-- > > >> libavcodec/x86/mpegvideoencdsp_init.c | 6 +++--- > > >> 9 files changed, 26 insertions(+), 26 deletions(-) > > > > > > LGTM, also all similar things should be ok > > > > > > [...] > > > > > > > Unfortunately, it is not so easy. The first version of this patchset > > (this here) forgot to update the definitions of several loongarch > > functions, leading to lots of red on patchwork. The second version fixed > > the compilation error, but forgot some constifications due to > > unfortunate oversights. For the third version, I wanted to actually > > compile loongarch instead of just staring at the code; but the > > GCC-cross-compiler does not seem to support lsx and lasx (and looking at > > the loongarch-code in GCC makes me believe that they are just not > > supported (yet)). Therefore I resorted to creating dummy-functions for > > all the __lasx_* and __lsx_* functions (they show no more > > const-warnings). I wanted to let the FATE-loongarch-box test this once > > more (and tell me whether there are still any issues left), yet this box > > is no longer active since a few days (for reasons unknown). Can you > > compile the lsx and lasx code (after all, you committed all the > > loongarch code)? > > i have no easy way to test loongarch, what i can test is qemu-mips. > i think i have said that a few times already. > > I do have a loongson box that is IIRC ready to be shipped (within EU) to > whoever volunteers to maintain that box for FFmpeg. I dont know if that > box would help with the current code. The OS will liklely need to be updated > and IIRC this has no normal update mechanism) I didnt touch this box for a > really long time. What OS is it? I could conceivably host such a machine and give other devs SSH access to it, if it does not require too much maintenance and/or electricity. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".