From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF11243BE5 for ; Fri, 22 Jul 2022 15:39:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E09DE68B73B; Fri, 22 Jul 2022 18:39:10 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7956E68B69E for ; Fri, 22 Jul 2022 18:39:09 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3B8D5240179 for ; Fri, 22 Jul 2022 17:39:09 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 323IO3_iXIUA for ; Fri, 22 Jul 2022 17:39:07 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E57522400F5 for ; Fri, 22 Jul 2022 17:39:07 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 2BF511601B2; Fri, 22 Jul 2022 17:39:08 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDB6PR0101MB2214720C8C529845975A0DAC8FAC9=40DB6PR01?= =?utf-8?q?01MB2214=2Eeurprd01=2Eprod=2Eexchangelabs=2Ecom=3E?= References: <20220616195534.5278-1-anton@khirnov.net> <20220616195534.5278-21-anton@khirnov.net> =?utf-8?q?=3CDB6PR0101MB2214720C?= =?utf-8?q?8C529845975A0DAC8FAC9=40DB6PR0101MB2214=2Eeurprd01=2Eprod=2Eexcha?= =?utf-8?q?ngelabs=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 22 Jul 2022 17:39:08 +0200 Message-ID: <165850434814.15471.8515615540504966051@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 22/35] fftools: add an object pool X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, Quoting Andreas Rheinhardt (2022-06-16 23:41:36) > AVFifos are often used with non-POD elements that need custom init, > reset (unref) and free callbacks (in addition to the move callbacks > already supported). So why not add it to AVFifo? The only drawback to > this that I see is that the pool could not be shared among multiple > AVFifos, but apart from that it should support the usecases that you > propose and do so in a way that avoids having to drain the fifos > manually when freeing it. Since neither of us seems to have much time to deal with this right now --- would you object to me pushing this set as is (Michael confirmed on IRC he is done testing it) and leaving the objpool question for later? Objpool is fully private, so it can always be changed or removed at will. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".