From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B9FD43B5B for ; Mon, 18 Jul 2022 18:15:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2636568B95E; Mon, 18 Jul 2022 21:15:40 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F04D68B671 for ; Mon, 18 Jul 2022 21:15:34 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id A1E33240179 for ; Mon, 18 Jul 2022 20:15:33 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id BxSj6N565XOk for ; Mon, 18 Jul 2022 20:15:33 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1EC8D2400F5 for ; Mon, 18 Jul 2022 20:15:33 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 315E51601B2; Mon, 18 Jul 2022 20:15:33 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <8f3313ba-de91-6ea7-6bef-03ea0dfe0d33@gmail.com> References: <20220717220619.GO2088045@pb2> <20220718071225.4446-1-anton@khirnov.net> <8f3313ba-de91-6ea7-6bef-03ea0dfe0d33@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 18 Jul 2022 20:15:33 +0200 Message-ID: <165816813316.15564.17775576086260685988@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx264: support AV_CODEC_CAP_ENCODER_RECON_FRAME X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2022-07-18 14:23:58) > On 7/18/2022 4:12 AM, Anton Khirnov wrote: > > --- > > libavcodec/libx264.c | 52 +++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 51 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > > index 98ec030865..5e360682e6 100644 > > --- a/libavcodec/libx264.c > > +++ b/libavcodec/libx264.c > > @@ -311,6 +311,25 @@ static void free_picture(AVCodecContext *ctx) > > pic->extra_sei.num_payloads = 0; > > } > > > > +static enum AVPixelFormat csp_to_pixfmt(int csp) > > +{ > > + switch (csp) { > > +#ifdef X264_CSP_I400 > > + case X264_CSP_I400: return AV_PIX_FMT_GRAY8; > > + case X264_CSP_I400 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_GRAY10; > > +#endif > > + case X264_CSP_I420: return AV_PIX_FMT_YUV420P; > > + case X264_CSP_I420 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_YUV420P10; > > + case X264_CSP_I422: return AV_PIX_FMT_YUV422P; > > + case X264_CSP_I422 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_YUV422P10; > > + case X264_CSP_I444: return AV_PIX_FMT_YUV444P; > > + case X264_CSP_I444 | X264_CSP_HIGH_DEPTH: return AV_PIX_FMT_YUV444P10; > > We're still supporting old x264 versions, so you should add some > considerations for 9 bit pixfmts. On X264_BUILD < 153, just check the > value of x264_bit_depth. Is there much point in continuing to support 5.5 year old x264? We could drop a lot of ugliness, including the abominable X264_init_static(). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".