From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA81D4359F for ; Mon, 18 Jul 2022 13:03:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D00268B877; Mon, 18 Jul 2022 16:02:58 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2681A68B4AF for ; Mon, 18 Jul 2022 16:02:52 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 927A4240179; Mon, 18 Jul 2022 15:02:51 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 1bcECmfuj0Wq; Mon, 18 Jul 2022 15:02:50 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3AD282400F5; Mon, 18 Jul 2022 15:02:50 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 4D9AF1601B2; Mon, 18 Jul 2022 15:02:50 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220712062735.20339-11-haihao.xiang@intel.com> References: <20220712062735.20339-1-haihao.xiang@intel.com> <20220712062735.20339-11-haihao.xiang@intel.com> Mail-Followup-To: FFmpeg development discussions and patches , Haihao Xiang , galinart Date: Mon, 18 Jul 2022 15:02:50 +0200 Message-ID: <165814937028.25016.15272296385260114959@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v10 10/13] lavu/hwcontext_qsv: make qsv hwdevice works with oneVPL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang , galinart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Xiang, Haihao (2022-07-12 08:27:32) > +static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg) > +{ > +#if CONFIG_VAAPI > +#if VA_CHECK_VERSION(1, 5, 0) > +#define LOCAL_VADISPLAYPCIID VADisplayPCIID > +#else > +#define LOCAL_VADISPLAYPCIID 21 > +#endif > + mfxStatus sts; > + VADisplay dpy = handle; > + VAStatus vas; > + VADisplayAttribute attr = { > + .type = LOCAL_VADISPLAYPCIID > + }; > + mfxVariant impl_value; > + > + vas = vaGetDisplayAttributes(dpy, &attr, 1); > + if (vas == VA_STATUS_SUCCESS && attr.flags != VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { > + impl_value.Type = MFX_VARIANT_TYPE_U16; > + impl_value.Data.U16 = (attr.value & 0xFFFF); > + sts = MFXSetConfigFilterProperty(cfg, > + (const mfxU8 *)"mfxExtendedDeviceId.DeviceID", impl_value); > + if (sts != MFX_ERR_NONE) { > + av_log(ctx, AV_LOG_ERROR, "Error adding a MFX configuration" > + "DeviceID property: %d.\n", sts); > + goto fail; > + } > + } else > + av_log(ctx, AV_LOG_WARNING, "Cannot get device id from the driver, the default " > + "MFX implementation will be loaded for this device. Please consider to " > + "upgrade the driver to support VAAPI 1.5.0. \n"); I would still prefer to fail here. The user requested a specific device, disregarding that request is evil. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".