From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration
Date: Mon, 18 Jul 2022 13:54:50 +0200
Message-ID: <165814529042.15564.14494283373191084325@lain.khirnov.net> (raw)
In-Reply-To: <4465711f-63bf-64b8-46f1-5dedd8769372@gmail.com>
Quoting James Almer (2022-07-18 13:49:18)
> On 7/18/2022 4:34 AM, Anton Khirnov wrote:
> > diff --git a/tests/ref/fate/exif-image-jpg b/tests/ref/fate/exif-image-jpg
> > index b942fc5a7b..2d5fe18d61 100644
> > --- a/tests/ref/fate/exif-image-jpg
> > +++ b/tests/ref/fate/exif-image-jpg
> > @@ -10,6 +10,8 @@ best_effort_timestamp=0
> > best_effort_timestamp_time=0.000000
> > pkt_duration=1
> > pkt_duration_time=0.040000
> > +duration=1
> > +duration_time=0.040000
> > pkt_pos=N/A
> > pkt_size=46095
> > width=400
> > @@ -27,30 +29,30 @@ color_space=bt470bg
> > color_primaries=unknown
> > color_transfer=unknown
> > chroma_location=center
> > -TAG:ImageDescription=
> > +TAG:ImageDescription=
> > TAG:Make=Canon
> > TAG:Model=Canon PowerShot SX200 IS
> > TAG:Orientation= 1
> > -TAG:XResolution= 180:1
> > -TAG:YResolution= 180:1
> > +TAG:XResolution= 180:1
> > +TAG:YResolution= 180:1
> > TAG:ResolutionUnit= 2
> > TAG:DateTime=2013:07:18 13:12:03
> > TAG:YCbCrPositioning= 2
> > -TAG:ExposureTime= 1:1250
> > -TAG:FNumber= 40:10
> > +TAG:ExposureTime= 1:1250
> > +TAG:FNumber= 40:10
> > TAG:ISOSpeedRatings= 160
> > TAG:ExifVersion= 48, 50, 50, 49
> > TAG:DateTimeOriginal=2013:07:18 13:12:03
> > TAG:DateTimeDigitized=2013:07:18 13:12:03
> > TAG:ComponentsConfiguration= 1, 2, 3, 0
> > -TAG:CompressedBitsPerPixel= 3:1
> > -TAG:ShutterSpeedValue= 329:32
> > -TAG:ApertureValue= 128:32
> > -TAG:ExposureBiasValue= 0:3
> > -TAG:MaxApertureValue= 113:32
> > +TAG:CompressedBitsPerPixel= 3:1
> > +TAG:ShutterSpeedValue= 329:32
> > +TAG:ApertureValue= 128:32
> > +TAG:ExposureBiasValue= 0:3
> > +TAG:MaxApertureValue= 113:32
> > TAG:MeteringMode= 5
> > TAG:Flash= 16
> > -TAG:FocalLength= 5000:1000
> > +TAG:FocalLength= 5000:1000
> > TAG:MakerNote=
> > 25, 0, 1, 0, 3, 0, 48, 0, 0, 0, 28, 4, 0, 0, 2, 0
> > 3, 0, 4, 0, 0, 0, 124, 4, 0, 0, 3, 0, 3, 0, 4, 0
>
> This and exif-image-webp got a lot of suspicious changes, adding
> trailing whitespaces to several lines.
That whitespace is actually present in the tags exported from lavc.
Don't know why it wasn't present in the refs before.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-18 11:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:17 [FFmpeg-devel] [PATCH 1/9] lavu/frame: add a duration field to AVFrame Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 2/9] lavc: use AVFrame.duration instead of AVFrame.pkt_duration Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 3/9] lavfi: " Anton Khirnov
2022-07-13 15:02 ` Nicolas George
2022-07-14 8:46 ` Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 4/9] lavf: " Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 5/9] lavd: " Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 6/9] ffprobe: " Anton Khirnov
2022-07-13 12:39 ` James Almer
2022-07-14 9:34 ` Anton Khirnov
2022-07-14 11:50 ` James Almer
2022-07-18 7:34 ` [FFmpeg-devel] [PATCH] " Anton Khirnov
2022-07-18 8:23 ` Nicolas George
2022-07-18 8:44 ` Anton Khirnov
2022-07-18 11:49 ` James Almer
2022-07-18 11:54 ` Anton Khirnov [this message]
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 7/9] ffmpeg: " Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 8/9] tests/api: " Anton Khirnov
2022-07-13 9:17 ` [FFmpeg-devel] [PATCH 9/9] lavfi/vf_showinfo: print frame durations Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165814529042.15564.14494283373191084325@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git