From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3B07C43589 for ; Mon, 18 Jul 2022 11:28:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4A6E368B845; Mon, 18 Jul 2022 14:28:13 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A083368B655 for ; Mon, 18 Jul 2022 14:28:06 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 24524240179 for ; Mon, 18 Jul 2022 13:28:06 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id tI98dxJrlrUm for ; Mon, 18 Jul 2022 13:28:05 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5A78B2400F5 for ; Mon, 18 Jul 2022 13:28:05 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 73AD21601B2; Mon, 18 Jul 2022 13:28:05 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220714180954.GD2088045@pb2> References: <20220601203337.1116134-1-matthieu.bouron@gmail.com> <20220602191331.GR396728@pb2> <20220611153518.GF396728@pb2> <20220714180954.GD2088045@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 18 Jul 2022 13:28:05 +0200 Message-ID: <165814368544.25016.12623279384501712564@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] swscale: add NV16 input/output X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2022-07-14 20:09:54) > On Fri, Jul 01, 2022 at 10:08:14AM +0200, Matthieu Bouron wrote: > > On Sat, Jun 11, 2022 at 5:35 PM Michael Niedermayer > > wrote: > > > > > On Fri, Jun 10, 2022 at 04:11:10PM +0200, Matthieu Bouron wrote: > > > > On Thu, Jun 2, 2022 at 9:13 PM Michael Niedermayer < > > > michael@niedermayer.cc> > > > > wrote: > > > > > > > > > On Wed, Jun 01, 2022 at 10:33:37PM +0200, Matthieu Bouron wrote: > > > > > > --- > > > > > > libswscale/input.c | 1 + > > > > > > libswscale/utils.c | 1 + > > > > > > libswscale/version.h | 2 +- > > > > > > tests/ref/fate/filter-pixdesc-nv16 | 1 + > > > > > > tests/ref/fate/filter-pixfmts-copy | 1 + > > > > > > tests/ref/fate/filter-pixfmts-crop | 1 + > > > > > > tests/ref/fate/filter-pixfmts-field | 1 + > > > > > > tests/ref/fate/filter-pixfmts-fieldorder | 1 + > > > > > > tests/ref/fate/filter-pixfmts-hflip | 1 + > > > > > > tests/ref/fate/filter-pixfmts-il | 1 + > > > > > > tests/ref/fate/filter-pixfmts-null | 1 + > > > > > > tests/ref/fate/filter-pixfmts-pad | 1 + > > > > > > tests/ref/fate/filter-pixfmts-scale | 1 + > > > > > > tests/ref/fate/filter-pixfmts-vflip | 1 + > > > > > > 14 files changed, 14 insertions(+), 1 deletion(-) > > > > > > create mode 100644 tests/ref/fate/filter-pixdesc-nv16 > > > > > > > > > > > > > > Sorry for the late reply > > > > > > > > > > > > > has this been tested ? (various scaled and non scaled) variants ? > > > > > > > > > > > > > I only tested the non scaled variant using the command line doing > > > multiple > > > > round trips to/from nv16. > > > > Is there a particular test procedure to validate every variants ? > > > > > > you can test manually or use something like > > > libswscale/tests/swscale.c > > > > > > > I manually tested without any issue: il, field, fieldorder, copy, crop, > > hflip, null, pad, scale and vflip. > > if that included up & down scaling while changing format then it should be ok Seems to work for me. Will push soonish if nobody objects. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".