Re: [FFmpeg-devel] [PATCH] swscale: add NV16 input/output

[Anton Khirnov <anton@khirnov.net>]

Quoting Michael Niedermayer (2022-07-14 20:09:54)
> On Fri, Jul 01, 2022 at 10:08:14AM +0200, Matthieu Bouron wrote:
> > On Sat, Jun 11, 2022 at 5:35 PM Michael Niedermayer <michael@niedermayer.cc>
> > wrote:
> > 
> > > On Fri, Jun 10, 2022 at 04:11:10PM +0200, Matthieu Bouron wrote:
> > > > On Thu, Jun 2, 2022 at 9:13 PM Michael Niedermayer <
> > > michael@niedermayer.cc>
> > > > wrote:
> > > >
> > > > > On Wed, Jun 01, 2022 at 10:33:37PM +0200, Matthieu Bouron wrote:
> > > > > > ---
> > > > > >  libswscale/input.c                       | 1 +
> > > > > >  libswscale/utils.c                       | 1 +
> > > > > >  libswscale/version.h                     | 2 +-
> > > > > >  tests/ref/fate/filter-pixdesc-nv16       | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-copy       | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-crop       | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-field      | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-fieldorder | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-hflip      | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-il         | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-null       | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-pad        | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-scale      | 1 +
> > > > > >  tests/ref/fate/filter-pixfmts-vflip      | 1 +
> > > > > >  14 files changed, 14 insertions(+), 1 deletion(-)
> > > > > >  create mode 100644 tests/ref/fate/filter-pixdesc-nv16
> > > > >
> > > > >
> > > > Sorry for the late reply
> > > >
> > > >
> > > > > has this been tested ? (various scaled and non scaled) variants ?
> > > > >
> > > >
> > > > I only tested the non scaled variant using the command line doing
> > > multiple
> > > > round trips to/from nv16.
> > > > Is there a particular test procedure to validate every variants ?
> > >
> > > you can test manually or use something like
> > > libswscale/tests/swscale.c
> > >
> > 
> > I manually tested without any issue: il, field, fieldorder, copy, crop,
> > hflip, null, pad, scale and vflip.
> 
> if that included up & down scaling while changing format then it should be ok

Seems to work for me.

Will push soonish if nobody objects.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".