From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 152C0434D0 for ; Thu, 14 Jul 2022 09:34:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D0EB68BA19; Thu, 14 Jul 2022 12:34:41 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F59368B9CB for ; Thu, 14 Jul 2022 12:34:35 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5DD80240179 for ; Thu, 14 Jul 2022 11:34:34 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id t7Sfom_GOPQN for ; Thu, 14 Jul 2022 11:34:33 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 06F432400F5 for ; Thu, 14 Jul 2022 11:34:33 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 142F01601B2; Thu, 14 Jul 2022 11:34:33 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <978501a3-acef-cc0f-f655-ca1401594ad6@gmail.com> References: <20220713091725.16638-1-anton@khirnov.net> <20220713091725.16638-6-anton@khirnov.net> <978501a3-acef-cc0f-f655-ca1401594ad6@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 14 Jul 2022 11:34:33 +0200 Message-ID: <165779127304.25016.8703565613875448010@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 6/9] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2022-07-13 14:39:20) > You should probably add new entries to the schema file instead. > > https://git.videolan.org/?p=ffmpeg.git;a=blob;f=doc/ffprobe.xsd;h=3af621a17ae884adfeacb7cd50c60e1553808188;hb=HEAD#l93 > > Once frame->pkt_duration is gone, ffprobe shouldn't keep printing a > frame->duration value as "pkt_duration" and "pkt_duration_time". > Also, if frame->duration is supposed to be able to have values other > than those we wrote to pkt_duration, maybe keep printing the latter with > the existing schema entries until it's all gone (You can use > AV_NOWARN_DEPRECATED() to shut compilers up). Well, the whole idea that values printed by ffprobe should precisely mirror the libav* API, up to the field names of our structs, seems quite questionable to me, IMO it makes more sense for it to provide a layer of abstraction over the libraries. But then again I neither maintain ffprobe, nor use it very much, so I wanted to keep changes to a minimum. If nobody has other plans for dealing with this then I can certainly make the changes you're sugesting. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".