Re: [FFmpeg-devel] [PATCH 6/9] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/9] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration
Date: Thu, 14 Jul 2022 11:34:33 +0200
Message-ID: <165779127304.25016.8703565613875448010@lain.khirnov.net> (raw)
In-Reply-To: <978501a3-acef-cc0f-f655-ca1401594ad6@gmail.com>

Quoting James Almer (2022-07-13 14:39:20)
> You should probably add new entries to the schema file instead.
> 
> https://git.videolan.org/?p=ffmpeg.git;a=blob;f=doc/ffprobe.xsd;h=3af621a17ae884adfeacb7cd50c60e1553808188;hb=HEAD#l93
> 
> Once frame->pkt_duration is gone, ffprobe shouldn't keep printing a 
> frame->duration value as "pkt_duration" and "pkt_duration_time".
> Also, if frame->duration is supposed to be able to have values other 
> than those we wrote to pkt_duration, maybe keep printing the latter with 
> the existing schema entries until it's all gone (You can use 
> AV_NOWARN_DEPRECATED() to shut compilers up).

Well, the whole idea that values printed by ffprobe should precisely
mirror the libav* API, up to the field names of our structs, seems quite
questionable to me, IMO it makes more sense for it to provide a layer of
abstraction over the libraries. But then again I neither maintain
ffprobe, nor use it very much, so I wanted to keep changes to a minimum.
If nobody has other plans for dealing with this then I can certainly
make the changes you're sugesting.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".