From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 16EB6434C2 for ; Thu, 14 Jul 2022 08:47:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 674D968B9E9; Thu, 14 Jul 2022 11:47:00 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB99668B908 for ; Thu, 14 Jul 2022 11:46:53 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5A678240179 for ; Thu, 14 Jul 2022 10:46:53 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id qRQ1_i6F7sSt for ; Thu, 14 Jul 2022 10:46:52 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 48A722400F5 for ; Thu, 14 Jul 2022 10:46:52 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 5565A1601B2; Thu, 14 Jul 2022 10:46:52 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20220713091725.16638-1-anton@khirnov.net> <20220713091725.16638-3-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 14 Jul 2022 10:46:52 +0200 Message-ID: <165778841230.25016.3520661998846984515@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 3/9] lavfi: use AVFrame.duration instead of AVFrame.pkt_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2022-07-13 17:02:04) > Anton Khirnov (12022-07-13): > > --- > > doc/filters.texi | 2 +- > > libavfilter/buffersrc.c | 7 +++++++ > > libavfilter/f_loop.c | 14 ++++++++++++++ > > libavfilter/vf_deshake_opencl.c | 7 +++++++ > > libavfilter/vf_drawtext.c | 16 ++++++++++++++++ > > 5 files changed, 45 insertions(+), 1 deletion(-) > > No objection from me. > > But pkt_duration is mostly unused in libavfilter: the authoritative > information about a packet duration is given by the timestamp of the > next packet. What f_loop and vf_deshake_opencl currently do is slightly > bogus. I am aware. Timestamp of the next packet requires you to have the next packet, which means extra latency, so using durations is better. My plan for the future is to handle durations in all filters that may modify timestamps, so durations propagate through lavfi properly. Later on, some mechanism could be added to automatically compute durations when they are not available on input, so that filters may rely on the duration being known and don't need to buffer frames themselves. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".