From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 49F5C4345A for ; Wed, 13 Jul 2022 11:28:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0AE9368B914; Wed, 13 Jul 2022 14:27:59 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A080968B616 for ; Wed, 13 Jul 2022 14:27:52 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 2B840240179 for ; Wed, 13 Jul 2022 13:27:52 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 13xfS-fYFTP9 for ; Wed, 13 Jul 2022 13:27:51 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id ABD312400F5 for ; Wed, 13 Jul 2022 13:27:51 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id C0E441601B2; Wed, 13 Jul 2022 13:27:51 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDB6PR0101MB2214B002AE7F458441AB00D78F879=40DB6PR01?= =?utf-8?q?01MB2214=2Eeurprd01=2Eprod=2Eexchangelabs=2Ecom=3E?= References: <20220711091850.4158449-1-martin@martin.st> =?utf-8?q?=3CDB6PR01?= =?utf-8?q?01MB22142C52AD742E44823312998F879=40DB6PR0101MB2214=2Eeurprd01=2E?= =?utf-8?q?prod=2Eexchangelabs=2Ecom=3E?= <447d92d5-596a-59c5-5bb4-3c50c6bcd3b3@martin.st> =?utf-8?q?=3CDB6PR0101MB22?= =?utf-8?q?14B002AE7F458441AB00D78F879=40DB6PR0101MB2214=2Eeurprd01=2Eprod?= =?utf-8?q?=2Eexchangelabs=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 13 Jul 2022 13:27:51 +0200 Message-ID: <165771167175.25016.966124802932769566@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavutil: Add av_visibility_hidden for setting hidden symbol visibility X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2022-07-11 12:57:32) > > > > Good point - attribute.h would otherwise have been the natural spot, but > > I agree that it'd be better to not make it public at all. In what header > > would you prefer to have it? > > > > The typical place we put such things is libavutil/internal.h. misc headers are evil how about a non-installed attribute_internal.h? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".