From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A0C0B43990 for ; Mon, 4 Jul 2022 06:45:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 50A3068B9E9; Mon, 4 Jul 2022 09:45:21 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 080C768B9DA for ; Mon, 4 Jul 2022 09:45:15 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 8AB77240179 for ; Mon, 4 Jul 2022 08:45:14 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Wyjq9J8F1t2e for ; Mon, 4 Jul 2022 08:45:13 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4937C2400F5 for ; Mon, 4 Jul 2022 08:45:13 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 69A2B1601B2; Mon, 4 Jul 2022 08:45:13 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CBY5PR11MB3879CE08DC7589348CB1CBFDF8BE9=40BY5PR11MB?= =?utf-8?q?3879=2Enamprd11=2Eprod=2Eoutlook=2Ecom=3E?= References: <20220623053242.360909-1-wenbin.chen@intel.com> <165675474959.31466.10582792568629584963@lain.khirnov.net> =?utf-8?q?=3CBY5?= =?utf-8?q?PR11MB3879CE08DC7589348CB1CBFDF8BE9=40BY5PR11MB3879=2Enamprd11=2E?= =?utf-8?q?prod=2Eoutlook=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 04 Jul 2022 08:45:13 +0200 Message-ID: <165691711340.12703.7049243388119130188@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3] libavcodec/qsvenc: Enable fixed QP configure in qsv CQP runtime X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Chen, Wenbin (2022-07-04 08:33:49) > > Why is this using frame metadata rather than the AVVideoEncParams side > > data? > > The usage of AVVideoEncParams relates to the "qp" variable in mfxEncodeCtrl which is passed > to MFXVideoENCODE_encoderFrameAsync(). This variable in qsv is for per-frame QP > configuration. > There are other parameter changing supports I want to add besides QP, for > example, gop_size, max_frame_size, intra_refresh. These parameter configurations are not > all included in mfxEncodeCtrl, so I choose to use MFXVideoENCODE_Reset() to do this. This > code changes the encoding parameters which means these changes are applied to all > the following frames, but AVVideoEncParams is per-frame configuration, so I think > AVVideoEncParams is not suitable for this. AVFrame metadata is also per-frame, so your logic does not make sense to me. You could also just update the AVCodecContext/private context values directly or using AVOptions. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".