From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add AVFormatContext.first_pkt_wallclock
Date: Mon, 04 Jul 2022 06:42:46 +0200
Message-ID: <165690976603.12703.846770648467387985@lain.khirnov.net> (raw)
In-Reply-To: <8e7a7bee-01b5-b9a5-4589-9982f7687d53@gyani.pro>
Quoting Gyan Doshi (2022-07-02 11:51:49)
>
>
> On 2022-07-02 02:12 pm, Anton Khirnov wrote:
> > Quoting Gyan Doshi (2022-07-01 13:07:13)
> >>
> >> On 2022-07-01 03:20 pm, Anton Khirnov wrote:
> >>> Quoting Gyan Doshi (2022-06-28 08:40:58)
> >>>> On 2022-06-28 10:43 am, Anton Khirnov wrote:
> >>>>> Quoting Gyan Doshi (2022-06-25 10:29:50)
> >>>>>> Stores wallclock time for the first packet received.
> >>>>>> Used for crude sync offset among inputs.
> >>>>>> ---
> >>>>>> doc/APIchanges | 3 +++
> >>>>>> libavformat/avformat.h | 10 ++++++++++
> >>>>>> libavformat/demux.c | 3 +++
> >>>>>> libavformat/options.c | 1 +
> >>>>>> libavformat/version.h | 2 +-
> >>>>>> 5 files changed, 18 insertions(+), 1 deletion(-)
> >>>>> Why should this be in the library? Seems to me this can be just as
> >>>>> easily done by the callers who need it.
> >>>> To not add some extra latency, just like how
> >>>> `use_wallclock_as_timestamps` was implemented inside lavf.
> >>> Where would that extra latency come from?
> >> The interval between its current assigment inside ff_read_packet() and
> >> the chance for assignment in process_input() in ffmpeg.c
> > And why would there be a significant delay there?
>
> With multiple inputs, get_input_packet_mt() will populate each input
> queue in async whereas process_input() will be called on that input at
> best in a round robin fashion depending on choose_output().
So why should this information not be set by get_input_packet_mt() then?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-07-04 4:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 8:29 Gyan Doshi
2022-06-25 8:29 ` [FFmpeg-devel] [PATCH v2 2/2] ffmpeg: add option -isync Gyan Doshi
2022-06-27 13:25 ` Gyan Doshi
2022-07-01 4:16 ` Gyan Doshi
2022-07-01 10:03 ` Anton Khirnov
2022-07-01 11:03 ` Gyan Doshi
2022-07-02 8:42 ` Anton Khirnov
2022-07-02 9:51 ` Gyan Doshi
2022-07-04 3:47 ` Gyan Doshi
2022-07-04 6:29 ` Anton Khirnov
2022-07-04 6:21 ` Anton Khirnov
2022-07-04 8:20 ` Gyan Doshi
2022-07-05 16:15 ` Anton Khirnov
2022-07-05 17:10 ` Gyan Doshi
2022-07-05 17:24 ` Anton Khirnov
2022-07-06 4:16 ` Gyan Doshi
2022-06-28 5:13 ` [FFmpeg-devel] [PATCH v2 1/2] avformat: add AVFormatContext.first_pkt_wallclock Anton Khirnov
2022-06-28 6:40 ` Gyan Doshi
2022-06-28 7:50 ` Andreas Rheinhardt
2022-06-28 8:35 ` Gyan Doshi
2022-07-01 9:50 ` Anton Khirnov
2022-07-01 11:07 ` Gyan Doshi
2022-07-02 8:42 ` Anton Khirnov
2022-07-02 9:51 ` Gyan Doshi
2022-07-04 4:42 ` Anton Khirnov [this message]
2022-07-04 5:23 ` Gyan Doshi
-- strict thread matches above, loose matches on Subject: below --
2022-06-25 8:13 Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165690976603.12703.846770648467387985@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git