From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9F51C4335B for ; Sat, 2 Jul 2022 08:50:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D971768B874; Sat, 2 Jul 2022 11:50:46 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5DF3568B85C for ; Sat, 2 Jul 2022 11:50:40 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9589E240179 for ; Sat, 2 Jul 2022 10:50:39 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id rkUxZ92dMYJe for ; Sat, 2 Jul 2022 10:50:38 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 8E5CA2400F5 for ; Sat, 2 Jul 2022 10:50:38 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id BE6BD1601B2; Sat, 2 Jul 2022 10:50:38 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CSN6PR11MB29908D2FFFD18BC7ABEE8C07C0BD9=40SN6PR11MB?= =?utf-8?q?2990=2Enamprd11=2Eprod=2Eoutlook=2Ecom=3E?= References: <20220630024558.1444-1-tong1.wu@intel.com> <165657859616.10358.12321681270835950968@lain.khirnov.net> =?utf-8?q?=3CDB6PR010?= =?utf-8?q?1MB22146D50C60E6E90FAF944BF8FBA9=40DB6PR0101MB2214=2Eeurprd01=2Ep?= =?utf-8?q?rod=2Eexchangelabs=2Ecom=3E?= =?utf-8?q?=3CSN6PR11M?= =?utf-8?q?B299062B5FFD2141BCC5D3508C0BD9=40SN6PR11MB2990=2Enamprd11=2Eprod?= =?utf-8?q?=2Eoutlook=2Ecom=3E_=3CSN6PR11MB29908D2FFFD18BC7ABEE8C07C0BD9=40S?= =?utf-8?q?N6PR11MB2990=2Enamprd11=2Eprod=2Eoutlook=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 02 Jul 2022 10:50:38 +0200 Message-ID: <165675183874.31466.190278937108789916@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avutil/hwcontext: add a function to get the AVHWDeviceType X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Wu, Tong1 (2022-07-01 08:51:28) > Plus, do you think adding a AV_PIX_FMT_FLAG_HWACCEL check for the > input pixel format and change the function name to > av_hwdevice_get_type_by_hwaccel_pix_fmt will help? I'd prefer not to, that name is way too long > Let users know only hardware pixel formats are acceptable for this > function and like I said at this moment not any hardware format is > supported by more than one hardware devices. Maybe just document in the doxy that it will return the preferred device type for a pixel format. Overall I don't insist on any changes here, mainly wondering if anyone can think of a potential future case where we'd want a single pixel format supported by multiple devices -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".