From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5445D4334F for ; Sat, 2 Jul 2022 08:38:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9994C68B867; Sat, 2 Jul 2022 11:38:33 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B32FB68B710 for ; Sat, 2 Jul 2022 11:38:27 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 1A8D8240179 for ; Sat, 2 Jul 2022 10:38:27 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id aUAItCvM0xhD for ; Sat, 2 Jul 2022 10:38:26 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 97D972400F5 for ; Sat, 2 Jul 2022 10:38:26 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id CD7241601B2; Sat, 2 Jul 2022 10:38:26 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220701195300.GV396728@pb2> References: <20220628121400.20444-1-michael@niedermayer.cc> <20220628121400.20444-2-michael@niedermayer.cc> <165657934670.10358.3564375213466122817@lain.khirnov.net> <20220701195300.GV396728@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 02 Jul 2022 10:38:26 +0200 Message-ID: <165675110681.31466.8599184593020973018@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: Fix audio_drift_threshold check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2022-07-01 21:53:00) > On Thu, Jun 30, 2022 at 10:55:46AM +0200, Anton Khirnov wrote: > > Variant 2 is less bad, but the whole check seems hacky to me, since it > > seems to make assumptions about swr defaults > > > > Won't setting this unconditionally have the same effect? > > it has the same effect but its not so nice to the user to recommand extra > arguments which make no difference Sorry, I don't follow. What is recommending any arguments to the user here? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".