From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD40743311 for ; Fri, 1 Jul 2022 11:14:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BF5568B7B3; Fri, 1 Jul 2022 14:14:42 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ADFE768B41C for ; Fri, 1 Jul 2022 14:14:35 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 29916240179; Fri, 1 Jul 2022 13:14:35 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id mk-dd3o7lCDW; Fri, 1 Jul 2022 13:14:34 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 6D2752400F5; Fri, 1 Jul 2022 13:14:34 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id A4B171601B2; Fri, 1 Jul 2022 13:14:34 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDB6PR0101MB2214526C6DA30E12231D84AE8FBA9=40DB6PR01?= =?utf-8?q?01MB2214=2Eeurprd01=2Eprod=2Eexchangelabs=2Ecom=3E?= References: =?utf-8?q?=3CDB6PR0101MB2214B28F90001024D646E62B8FBA9=40DB6PR010?= =?utf-8?q?1MB2214=2Eeurprd01=2Eprod=2Eexchangelabs=2Ecom=3E_=3CDB6PR0101MB2?= =?utf-8?q?214526C6DA30E12231D84AE8FBA9=40DB6PR0101MB2214=2Eeurprd01=2Eprod?= =?utf-8?q?=2Eexchangelabs=2Ecom=3E?= Mail-Followup-To: FFmpeg development discussions and patches , Andreas Rheinhardt Date: Fri, 01 Jul 2022 13:14:34 +0200 Message-ID: <165667407464.10358.9237444868043899068@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 07/18] avcodec/hevc_mvs: Pass HEVCLocalContext when slice-threading X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Andreas Rheinhardt (2022-07-01 00:29:38) > The HEVC decoder has both HEVCContext and HEVCLocalContext > structures. The latter is supposed to be the structure > containing the per-slicethread state. > > Yet that is not how it is handled in practice: Each HEVCLocalContext > has a unique HEVCContext allocated for it and each of these > coincides except in exactly one field: The corresponding > HEVCLocalContext. This makes it possible to pass the HEVCContext > everywhere where logically a HEVCLocalContext should be used. > > This commit stops doing this for lavc/hevc_mvs.c; it also constifies > everything that is possible in order to ensure that no slice thread > accidentally modifies the main HEVCContext state. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/hevc_mvs.c | 56 +++++++++++++++++++++---------------------- > libavcodec/hevcdec.c | 27 +++++++++++---------- > libavcodec/hevcdec.h | 6 ++--- > 3 files changed, 45 insertions(+), 44 deletions(-) Looks very reasonable -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".