From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FADB4386D for ; Fri, 1 Jul 2022 08:57:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 887C768B84B; Fri, 1 Jul 2022 11:57:09 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07BAB68B657 for ; Fri, 1 Jul 2022 11:57:03 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 42365240179 for ; Fri, 1 Jul 2022 10:57:02 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id eCavPchA9ALi for ; Fri, 1 Jul 2022 10:57:01 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5F1162400F5 for ; Fri, 1 Jul 2022 10:57:01 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 6CF7E1601B2; Fri, 1 Jul 2022 10:57:01 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <00ba01d88604$24d5c450$6e814cf0$@samsung.com> References: =?utf-8?q?=3CCGME20220622064856eucas1p134bd4aad56d9d790c431d0959?= =?utf-8?q?5e1749e=40eucas1p1=2Esamsung=2Ecom=3E?= <00ba01d88604$24d5c450$6e814cf0$@samsung.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 01 Jul 2022 10:57:01 +0200 Message-ID: <165666582141.10358.14988505146106634090@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Dawid Kozinski (2022-06-22 08:48:55) > Prerequisites that must be met before adding new codec > - Added new entry to codec IDs list > - Added new entry to the codec descriptor list > - Bumped libavcodec minor version > - Changes in Changelog and MAINTAINERS files > > Signed-off-by: Dawid Kozinski > --- > Changelog | 3 ++- > MAINTAINERS | 2 ++ > libavcodec/codec_desc.c | 8 ++++++++ > libavcodec/codec_id.h | 1 + > libavcodec/profiles.c | 6 ++++++ > libavcodec/profiles.h | 1 + > libavcodec/version.h | 2 +- > 7 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/Changelog b/Changelog > index ef589705c4..0d230bde91 100644 > --- a/Changelog > +++ b/Changelog > @@ -67,7 +67,8 @@ version 5.0: > - VideoToolbox ProRes encoder > - anlmf audio filter > - IMF demuxer (experimental) > - > +- eXtra-fast Essential Video Encoder (XEVE) > +- eXtra-fast Essential Video Decoder (XEVD) These should be added in the commits that are actually adding the feature in question. > > version 4.4: > - AudioToolbox output device > diff --git a/MAINTAINERS b/MAINTAINERS > index 274fc89203..4b33d3c1b2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -205,6 +205,7 @@ Codecs: > libvpx* James Zern > libxavs.c Stefan Gehrer > libxavs2.c Huiwen Ren > + libxev*.c, evc_parser.c Dawid Kozinski > libzvbi-teletextdec.c Marton Balint > lzo.h, lzo.c Reimar Doeffinger > mdec.c Michael Niedermayer > @@ -425,6 +426,7 @@ Muxers/Demuxers: > dv.c Roman Shaposhnik > electronicarts.c Peter Ross > epafdec.c Paul B Mahol > + evcdec.c Dawid Kozinski > ffm* Baptiste Coudurier > flic.c Mike Melanson > flvdec.c Michael Niedermayer > diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c > index e2c1c67f5e..ea6f65ee9c 100644 > --- a/libavcodec/codec_desc.c > +++ b/libavcodec/codec_desc.c > @@ -1886,6 +1886,14 @@ static const AVCodecDescriptor codec_descriptors[] = > { > .long_name = NULL_IF_CONFIG_SMALL("QOI (Quite OK Image)"), > .props = AV_CODEC_PROP_INTRA_ONLY | AV_CODEC_PROP_LOSSLESS, > }, > + { > + .id = AV_CODEC_ID_EVC, > + .type = AVMEDIA_TYPE_VIDEO, > + .name = "evc", > + .long_name = NULL_IF_CONFIG_SMALL("MPEG-5 EVC (Essential Video > Coding)"), Your mailer broke the long line here, so the patch cannot be applied. You must send patches in a way that does not mangle them, such as attaching them or using git send-email. > + .props = AV_CODEC_PROP_LOSSY | AV_CODEC_PROP_REORDER, > + .profiles = NULL_IF_CONFIG_SMALL(ff_evc_profiles), > + }, > > /* various PCM "codecs" */ > { > diff --git a/libavcodec/codec_id.h b/libavcodec/codec_id.h > index 93856a16f2..7ed4aed861 100644 > --- a/libavcodec/codec_id.h > +++ b/libavcodec/codec_id.h > @@ -311,6 +311,7 @@ enum AVCodecID { > AV_CODEC_ID_VBN, > AV_CODEC_ID_JPEGXL, > AV_CODEC_ID_QOI, > + AV_CODEC_ID_EVC, > > /* various PCM "codecs" */ > AV_CODEC_ID_FIRST_AUDIO = 0x10000, ///< A dummy id pointing at the > start of audio codecs > diff --git a/libavcodec/profiles.c b/libavcodec/profiles.c > index 7af7fbeb13..a31244e0db 100644 > --- a/libavcodec/profiles.c > +++ b/libavcodec/profiles.c > @@ -181,4 +181,10 @@ const AVProfile ff_arib_caption_profiles[] = { > { FF_PROFILE_UNKNOWN } > }; > > +const AVProfile ff_evc_profiles[] = { > + { FF_PROFILE_EVC_BASELINE, "Baseline" }, > + { FF_PROFILE_EVC_MAIN, "Main" }, Those profiles are not actually added in this patch, so this will fail to build. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".