From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0CCDE42DB4 for ; Wed, 8 Jun 2022 07:09:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BCFC68B683; Wed, 8 Jun 2022 10:09:08 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E42AF68B5D4 for ; Wed, 8 Jun 2022 10:09:02 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 896C2240175 for ; Wed, 8 Jun 2022 09:09:02 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id PAdeZIG0dQUV for ; Wed, 8 Jun 2022 09:09:01 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id A408A2400F5 for ; Wed, 8 Jun 2022 09:09:01 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id B79951601B2; Wed, 8 Jun 2022 09:09:01 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDM8P223MB036505AC3D4B249D6F66F803BAA49=40DM8P223MB?= =?utf-8?q?0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?= References: <20220607115839.18515-1-anton@khirnov.net> =?utf-8?q?=3CDM8P223M?= =?utf-8?q?B03650454F09DE4D7C396CFB4BAA49=40DM8P223MB0365=2ENAMP223=2EPROD?= =?utf-8?q?=2EOUTLOOK=2ECOM=3E_=3CDM8P223MB0365397786EAF497BA5DC577BAA49=40D?= =?utf-8?q?M8P223MB0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?= <165466902879.5088.14253593912707356675@lain.khirnov.net> =?utf-8?q?=3CDM8P?= =?utf-8?q?223MB036505AC3D4B249D6F66F803BAA49=40DM8P223MB0365=2ENAMP223=2EPR?= =?utf-8?q?OD=2EOUTLOOK=2ECOM=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 08 Jun 2022 09:09:01 +0200 Message-ID: <165467214169.13099.10591659789295187077@lain> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain attachments to AV_CODEC_ID_TEXT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Soft Works (2022-06-08 08:39:21) > > Overall I'd say this just strengthens the case for my original lavc > > commit, since it is clearly helpful in exposing bugs in other code. > > As said already, I never doubted the validity of your patch, it was > about the effect and unacknowledged responsibilities. > > What do you want to do with the text attachment "none" caption? > Maybe a separate "cummy" codec id? Do we need to do anything about it? I am not a fan of inventing fake codec ids for every conceivable kind of data. lavf already exports the MIME type, that should be enough. Maybe the way it is printed can be improved, but that is not urgent as far as I'm concerned. > > I suppose it can make sense to log an error and continue when opening > > the codec fails. This could be useful also for probing genuinely broken > > streams where e.g. extradata parsing fails. > > > > There could also be an option like ffmpeg's -xerror that would make > > ffprobe exit on failure. > > Sounds good to me, but I'm not sure whether everybody would be ok > doing it exactly like this, as somebody might argue they would rely > on ffprobe failing in such cases. > I can submit a patch for that - unless no objections or better ideas > would appear.. https://xkcd.com/1172/ -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".