Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: stop mapping text/plain attachments to AV_CODEC_ID_TEXT

[Anton Khirnov <anton@khirnov.net>]

Quoting Soft Works (2022-06-08 08:39:21)
> > Overall I'd say this just strengthens the case for my original lavc
> > commit, since it is clearly helpful in exposing bugs in other code.
> 
> As said already, I never doubted the validity of your patch, it was
> about the effect and unacknowledged responsibilities.
> 
> What do you want to do with the text attachment "none" caption?
> Maybe a separate "cummy" codec id?

Do we need to do anything about it? I am not a fan of inventing fake
codec ids for every conceivable kind of data. lavf already exports the
MIME type, that should be enough. Maybe the way it is printed can be
improved, but that is not urgent as far as I'm concerned.

> > I suppose it can make sense to log an error and continue when opening
> > the codec fails. This could be useful also for probing genuinely broken
> > streams where e.g. extradata parsing fails.
> > 
> > There could also be an option like ffmpeg's -xerror that would make
> > ffprobe exit on failure.
> 
> Sounds good to me, but I'm not sure whether everybody would be ok
> doing it exactly like this, as somebody might argue they would rely
> on ffprobe failing in such cases. 
> I can submit a patch for that - unless no objections or better ideas
> would appear..

https://xkcd.com/1172/

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".