From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2C6B14330C for ; Wed, 1 Jun 2022 09:45:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEA8A68B6B9; Wed, 1 Jun 2022 12:45:23 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A837F68B57A for ; Wed, 1 Jun 2022 12:45:17 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 9AE40240175 for ; Wed, 1 Jun 2022 11:45:16 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id ul2_G1hctJ7i for ; Wed, 1 Jun 2022 11:45:15 +0200 (CEST) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3C5672400F5 for ; Wed, 1 Jun 2022 11:45:15 +0200 (CEST) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 600B71601B2; Wed, 1 Jun 2022 11:45:15 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <6c55b4a0-4c84-a1b9-cdf3-ae3e7e527f68@gmail.com> References: <6c55b4a0-4c84-a1b9-cdf3-ae3e7e527f68@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 01 Jun 2022 11:45:15 +0200 Message-ID: <165407671531.13099.17321905881119977859@lain> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv_2_rgb: fix access to memory past the frame data in yuv to rgb conversion X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Vardan Margaryan (2022-05-23 18:06:16) > Y, U, V data is loaded at the end of the current iteration for the next > iteration. > It results in memory access past the frame data on the last iteration > (that data is never used after the loading). > > So load data at the start of the iteration, so that only useful data is > loaded. > > Signed-off-by: Vardan Margaryan > --- > libswscale/x86/yuv_2_rgb.asm | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) I'm not an expert on this code, but the patch looks good and it fixes some invalid reads for me, so will push in a few days if nobody objects. Also note that your mailer mangled the patch, so it could not be applied automatically with 'git am', please fix this in future submissions e.g. by attaching the patch or sending it with git send-email. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".