From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] swscale/x86/yuv_2_rgb: fix access to memory past the frame data in yuv to rgb conversion
Date: Wed, 01 Jun 2022 11:45:15 +0200
Message-ID: <165407671531.13099.17321905881119977859@lain> (raw)
In-Reply-To: <6c55b4a0-4c84-a1b9-cdf3-ae3e7e527f68@gmail.com>
Quoting Vardan Margaryan (2022-05-23 18:06:16)
> Y, U, V data is loaded at the end of the current iteration for the next
> iteration.
> It results in memory access past the frame data on the last iteration
> (that data is never used after the loading).
>
> So load data at the start of the iteration, so that only useful data is
> loaded.
>
> Signed-off-by: Vardan Margaryan <v.t.margaryan@gmail.com>
> ---
> libswscale/x86/yuv_2_rgb.asm | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
I'm not an expert on this code, but the patch looks good and it fixes
some invalid reads for me, so will push in a few days if nobody objects.
Also note that your mailer mangled the patch, so it could not be applied
automatically with 'git am', please fix this in future submissions e.g.
by attaching the patch or sending it with git send-email.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-06-01 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 16:06 Vardan Margaryan
2022-06-01 9:45 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165407671531.13099.17321905881119977859@lain \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git