Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests
Date: Mon, 30 May 2022 12:24:15 +0200
Message-ID: <165390625527.5088.1732998558650448774@lain.red.khirnov.net> (raw)
In-Reply-To: =?utf-8?q?=3CDM8P223MB0365563D28C4B45BCC0AD382BADD9=40DM8P223MB?= =?utf-8?q?0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?=

Quoting Soft Works (2022-05-30 10:08:11)
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Anton Khirnov
> > Sent: Monday, May 30, 2022 9:35 AM
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem
> > alignment for vsynth..mpeg2-422 tests
> > 
> > Quoting Soft Works (2022-05-28 15:17:54)
> > > Do you have a better idea?
> > >
> > > The one advantage of this method is that you don’t need to change
> > compilation parameters
> > > nor  any source code. It’s only a runtime flag being set only for
> > this specific family of tests.
> > 
> > At the very least, I would expect the commit message to explain what
> > exactly the problem is, and why is it fixed in this seemingly ad-hoc
> > manner.
> > 
> > "limit mem alignment to fix failing tests" explains nothing.
> 
> 
> There was a longer conversation ("FATE Errors") with a number of
> people, I'm not sure whether you followed.

I saw the thread, I did not read it in enough detail to understand the
cause of the errors.

> I submitted this as a possible way to work around the issue. If you
> find that patch acceptable, then I'll gladly adjust the commit message
> with a detailed explanation.
> It's just that I learned that it's not very effective to spend a lot
> of time on things that are likely to get rejected or ignored.

From a first glance, this looks very ad-hoc (i.e. a hack). But ugly
hacks may sometimes be temporarily acceptable if a proper solution
requires too much work and the problem needs to be fixed ASAP.

So whether the patch is acceptable or not really depends on what the
problem is and why are you fixing it in this specific way.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".