From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests
Date: Mon, 30 May 2022 09:35:20 +0200
Message-ID: <165389612020.13099.3091905613010095028@lain> (raw)
In-Reply-To: =?utf-8?q?=3CDM8P223MB03659B54B6A1FBA3961A192ABADB9=40DM8P223MB?= =?utf-8?q?0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?=
Quoting Soft Works (2022-05-28 15:17:54)
> Do you have a better idea?
>
> The one advantage of this method is that you don’t need to change compilation parameters
> nor any source code. It’s only a runtime flag being set only for this specific family of tests.
At the very least, I would expect the commit message to explain what
exactly the problem is, and why is it fixed in this seemingly ad-hoc
manner.
"limit mem alignment to fix failing tests" explains nothing.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-30 7:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 9:08 [FFmpeg-devel] [PATCH] " softworkz
2022-05-28 10:19 ` [FFmpeg-devel] [PATCH v2] " softworkz
2022-05-28 13:10 ` Kieran Kunhya
2022-05-28 13:17 ` Soft Works
2022-05-30 7:35 ` Anton Khirnov [this message]
2022-05-30 8:08 ` Soft Works
2022-05-30 8:17 ` Soft Works
2022-05-30 8:35 ` Soft Works
2022-05-30 9:06 ` Paul B Mahol
2022-05-30 9:26 ` Soft Works
2022-05-30 10:31 ` Anton Khirnov
2022-05-30 10:24 ` Anton Khirnov
2022-05-30 10:56 ` Soft Works
2022-05-30 10:27 ` Anton Khirnov
2022-05-30 10:50 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165389612020.13099.3091905613010095028@lain \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git