From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A80C5431B1 for ; Tue, 24 May 2022 15:10:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1FF0568B4E6; Tue, 24 May 2022 18:10:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4662068B47B for ; Tue, 24 May 2022 18:10:19 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5A9D1240175; Tue, 24 May 2022 17:10:18 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id wL7gsg_nlYjA; Tue, 24 May 2022 17:10:16 +0200 (CEST) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E9BAA2400F5; Tue, 24 May 2022 17:10:16 +0200 (CEST) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 5466E1601B2; Tue, 24 May 2022 17:10:17 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220523210139.19480-2-leo.izen@gmail.com> References: <20220523210139.19480-1-leo.izen@gmail.com> <20220523210139.19480-2-leo.izen@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Leo Izen Date: Tue, 24 May 2022 17:10:17 +0200 Message-ID: <165340501730.13099.6788687226305200593@lain> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutil/csp: create public API for colorspace structs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2022-05-23 23:01:39) > diff --git a/libavutil/csp.h b/libavutil/csp.h > new file mode 100644 > index 0000000000..ea7400d1e5 > --- /dev/null > +++ b/libavutil/csp.h > @@ -0,0 +1,53 @@ > +/* > + * Copyright (c) 2016 Ronald S. Bultje > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +#ifndef AVUTIL_CSP_H > +#define AVUTIL_CSP_H > + > +#include "pixfmt.h" > +#include "rational.h" > + > +#define AVUTIL_CSP_DENOM 100000 This should be documented. > + > +typedef struct AVLumaCoefficients { > + AVRational cr, cg, cb; > +} AVLumaCoefficients; > + > +typedef struct AVCIExy { > + AVRational x, y; > +} AVCIExy; > + > +typedef struct AVPrimaryCoefficients { > + AVCIExy r, g, b; > +} AVPrimaryCoefficients; > + > +typedef AVCIExy AVWhitepointCoefficients; > + > +typedef struct AVColorPrimariesDesc { > + AVWhitepointCoefficients wp; > + AVPrimaryCoefficients prim; > +} AVColorPrimariesDesc; > + > +/* Returns AVCOL_PRI_UNSPECIFIED if no clear match can be identified */ > +enum AVColorPrimaries av_detect_color_primaries(const AVColorPrimariesDesc *prm); > + > +const AVColorPrimariesDesc *av_get_color_primaries(enum AVColorPrimaries prm); > +const AVLumaCoefficients *av_get_luma_coefficients(enum AVColorSpace csp); The names should be consistently namespaced along the lines of av__(). E.g. av_csp_primaries_desc_from_id()/av_csp_primaries_id_from_desc() -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".