Re: [FFmpeg-devel] [PATCH v4 1/1] avutil/csp: create public API for colorspace structs

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Leo Izen <leo.izen@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v4 1/1] avutil/csp: create public API for colorspace structs
Date: Tue, 24 May 2022 17:10:17 +0200
Message-ID: <165340501730.13099.6788687226305200593@lain> (raw)
In-Reply-To: <20220523210139.19480-2-leo.izen@gmail.com>

Quoting Leo Izen (2022-05-23 23:01:39)
> diff --git a/libavutil/csp.h b/libavutil/csp.h
> new file mode 100644
> index 0000000000..ea7400d1e5
> --- /dev/null
> +++ b/libavutil/csp.h
> @@ -0,0 +1,53 @@
> +/*
> + * Copyright (c) 2016 Ronald S. Bultje <rsbultje@gmail.com>
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#ifndef AVUTIL_CSP_H
> +#define AVUTIL_CSP_H
> +
> +#include "pixfmt.h"
> +#include "rational.h"
> +
> +#define AVUTIL_CSP_DENOM 100000

This should be documented.

> +
> +typedef struct AVLumaCoefficients {
> +    AVRational cr, cg, cb;
> +} AVLumaCoefficients;
> +
> +typedef struct AVCIExy {
> +    AVRational x, y;
> +} AVCIExy;
> +
> +typedef struct AVPrimaryCoefficients {
> +    AVCIExy r, g, b;
> +} AVPrimaryCoefficients;
> +
> +typedef AVCIExy AVWhitepointCoefficients;
> +
> +typedef struct AVColorPrimariesDesc {
> +    AVWhitepointCoefficients wp;
> +    AVPrimaryCoefficients prim;
> +} AVColorPrimariesDesc;
> +
> +/* Returns AVCOL_PRI_UNSPECIFIED if no clear match can be identified */
> +enum AVColorPrimaries av_detect_color_primaries(const AVColorPrimariesDesc *prm);
> +
> +const AVColorPrimariesDesc *av_get_color_primaries(enum AVColorPrimaries prm);
> +const AVLumaCoefficients *av_get_luma_coefficients(enum AVColorSpace csp);

The names should be consistently namespaced along the lines of
av_<namespace>_<action>(). E.g.
av_csp_primaries_desc_from_id()/av_csp_primaries_id_from_desc()

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".