From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B121B41213 for ; Thu, 19 May 2022 09:13:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CB8FF68B490; Thu, 19 May 2022 12:13:10 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F58F68B2C1 for ; Thu, 19 May 2022 12:13:04 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E272D240179 for ; Thu, 19 May 2022 11:13:02 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id e7wAILBN42RQ for ; Thu, 19 May 2022 11:13:02 +0200 (CEST) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 591232400F5 for ; Thu, 19 May 2022 11:13:02 +0200 (CEST) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id A35821601B2; Thu, 19 May 2022 11:12:58 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220511133037.GA897@gmail.com> References: <1651994221-11660-1-git-send-email-lance.lmwang@gmail.com> <1651994221-11660-2-git-send-email-lance.lmwang@gmail.com> <165227041068.13099.13911768827478787708@lain> <20220511133037.GA897@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 19 May 2022 11:12:58 +0200 Message-ID: <165295157862.13099.2165079091588914645@lain> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avcodec: add an AVCodecContext flag to export A53/SCTE20/DVD CC side data on demand X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting lance.lmwang@gmail.com (2022-05-11 15:30:37) > On Wed, May 11, 2022 at 02:00:10PM +0200, Anton Khirnov wrote: > > Quoting lance.lmwang@gmail.com (2022-05-08 09:17:01) > > > From: Limin Wang > > > > > > some samples include both A53 and SCTE20 data. Before the commit, both > > > of the will be exported, so the CC data will be repeated or garbarge > > > > Why would it be garbage? That sounds like a bug. > > Why can't we just export both? > for A53/SCTE20/DVDCC are exprted by A53_CC side data and they're sharing > the same a53_buf_ref to store the data, so if stream contains CC wrapped > as ATSC A53 packets + the same data wrapped as SCTE-20 packets, the CC > data will repeated. We can consider to add a new side data type if necessary, > but it's preferable to export A53_CC even it's SCTE20, so we can't export > both by A53_CC still. Does this apply to anything other than mpeg2? If not, it should be a codec-private option rather than a new global flag. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".