From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 02D7A42A09 for ; Wed, 11 May 2022 18:49:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A3D1468B446; Wed, 11 May 2022 21:49:22 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 561EC68B27E for ; Wed, 11 May 2022 21:49:16 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 1250B240179 for ; Wed, 11 May 2022 20:49:16 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id QLCJ5RhVjFn8 for ; Wed, 11 May 2022 20:49:15 +0200 (CEST) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 9B0862400F5 for ; Wed, 11 May 2022 20:49:15 +0200 (CEST) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 952C21601B2; Wed, 11 May 2022 20:49:15 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <642f0f54-799f-dbc4-6724-99ef21895ee5@gyani.pro> References: <20220510114054.1745-1-ffmpeg@gyani.pro> <165227016292.13099.10758598518855468997@lain> <642f0f54-799f-dbc4-6724-99ef21895ee5@gyani.pro> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 11 May 2022 20:49:15 +0200 Message-ID: <165229495558.13099.6133016962596120593@lain> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg: set user-set rotation for encoded streams too X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Gyan Doshi (2022-05-11 14:18:49) > > > On 2022-05-11 05:26 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-05-10 13:40:54) > >> So far, -metadata:s:v rotate would only be applied to streamcopied > >> video streams. > > Using -metadata for this functionality is a hack that should be removed, > > not extended. > > When there's a replacement for CLI users, sure. > Till then, there's no need for the disparity to be maintained. I disagree. You are adding new behavior, which will need to be maintained for backward compatibility and add extra burden on the person who would want to implement this properly. If you want this functionality, just add a new option. It's not that hard. There's plenty of hacks in ffmpeg already, we don't need any new ones. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".