From: "Rémi Denis-Courmont" <remi@remlab.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCHv4] checkasm/lpc: test compute_autocorr
Date: Thu, 30 May 2024 18:56:28 +0300
Message-ID: <16511818.nxky8H85ty@basile.remlab.net> (raw)
In-Reply-To: <ab0fdbe0-bd10-4fb1-a294-029857a65062@gmail.com>
Le keskiviikkona 29. toukokuuta 2024, 23.52.20 EEST James Almer a écrit :
> On 5/29/2024 4:42 PM, Rém
> > void checkasm_check_lpc(void)
> > {
> >
> > LPCContext ctx;
> >
> > - int len = rnd() % 5000;
> > + int len = 2000 + (rnd() % 1500) * 2;
>
> Instead of changing how len is generated, which will break known
> existing results for specific seeds in other tests, alter the value when
> passing it to test_compute_autocorr(), like
> apply_welch_window_{even,odd}() do.
Existing benchmarks are unstable and unreliable because of the varying length.
This was supposed to be contained by the 2000 minimum, but that means the
benchmarks are invalidated regardless of the parity change.
--
雷米‧德尼-库尔蒙
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-30 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 19:42 Rémi Denis-Courmont
2024-05-29 19:55 ` Andreas Rheinhardt
2024-05-29 20:31 ` Rémi Denis-Courmont
2024-05-29 20:32 ` Andreas Rheinhardt
2024-05-29 20:52 ` James Almer
2024-05-30 15:56 ` Rémi Denis-Courmont [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16511818.nxky8H85ty@basile.remlab.net \
--to=remi@remlab.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git