From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9028C42423 for ; Fri, 15 Apr 2022 10:39:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3386968B4BA; Fri, 15 Apr 2022 13:39:24 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B982068ADF3 for ; Fri, 15 Apr 2022 13:39:16 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EE324240179 for ; Fri, 15 Apr 2022 12:39:15 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id qysmnZv-Ldh8 for ; Fri, 15 Apr 2022 12:39:14 +0200 (CEST) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id BE5A42400F5 for ; Fri, 15 Apr 2022 12:39:14 +0200 (CEST) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 03F971601AD; Fri, 15 Apr 2022 12:39:15 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <9b4c385d-6d26-ef40-de65-0896e4f3b38a@gmail.com> References: <20220412055333.62424-1-leo.izen@gmail.com> <20220412055333.62424-4-leo.izen@gmail.com> <164995854773.17571.4529122301029877169@lain.red.khirnov.net> <9b4c385d-6d26-ef40-de65-0896e4f3b38a@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 15 Apr 2022 12:39:14 +0200 Message-ID: <165001915499.24258.15911732369228283522@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2022-04-15 03:37:20) > > On 4/14/22 13:49, Anton Khirnov wrote: > > Quoting Leo Izen (2022-04-12 07:53:32) > >> + > >> + while (1) { > >> + jret = JxlEncoderProcessOutput(ctx->encoder, &next_out, &available); > >> + if (jret == JXL_ENC_ERROR) { > >> + av_log(avctx, AV_LOG_ERROR, "Unspecified libjxl error occurred\n"); > >> + return AVERROR_EXTERNAL; > >> + } > >> + bytes_written = ctx->buffer_size - available; > >> + /* all data passed has been encoded */ > >> + if (jret == JXL_ENC_SUCCESS) > >> + break; > >> + if (jret == JXL_ENC_NEED_MORE_OUTPUT) { > > Is it possible for the encoder to return anything other than the three > > codes you're handling? Won't you get into an infinite loop if it does? > > > It's just these three, according to the documentation. > https://libjxl.readthedocs.io/en/latest/api_encoder.html So the end of the loop should be unreachable, as you always break, continue or return before. I would put return AVERROR_EXTERNAL there just in case. Beyond that I have no more comments on the set. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".