From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 4AE1A423DC
	for <ffmpegdev@gitmailbox.com>; Thu, 14 Apr 2022 17:49:21 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C496668B47C;
	Thu, 14 Apr 2022 20:49:18 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0753868B337
 for <ffmpeg-devel@ffmpeg.org>; Thu, 14 Apr 2022 20:49:12 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id EC98D240179;
 Thu, 14 Apr 2022 19:49:11 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id uGOnwp4AUrhj; Thu, 14 Apr 2022 19:49:11 +0200 (CEST)
Received: from lain.red.khirnov.net (lain.red.khirnov.net
 [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.red.khirnov.net",
 Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 8013A2400F5;
 Thu, 14 Apr 2022 19:49:11 +0200 (CEST)
Received: by lain.red.khirnov.net (Postfix, from userid 1000)
 id BBF191601AD; Thu, 14 Apr 2022 19:49:07 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20220412055333.62424-4-leo.izen@gmail.com>
References: <20220412055333.62424-1-leo.izen@gmail.com>
 <20220412055333.62424-4-leo.izen@gmail.com>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>, Leo Izen <leo.izen@gmail.com>
Date: Thu, 14 Apr 2022 19:49:07 +0200
Message-ID: <164995854773.17571.4529122301029877169@lain.red.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH v14 3/4] avcodec/libjxl: add Jpeg XL
 encoding via libjxl
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Leo Izen <leo.izen@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/164995854773.17571.4529122301029877169@lain.red.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Leo Izen (2022-04-12 07:53:32)
> +
> +    while (1) {
> +        jret = JxlEncoderProcessOutput(ctx->encoder, &next_out, &available);
> +        if (jret == JXL_ENC_ERROR) {
> +            av_log(avctx, AV_LOG_ERROR, "Unspecified libjxl error occurred\n");
> +            return AVERROR_EXTERNAL;
> +        }
> +        bytes_written = ctx->buffer_size - available;
> +        /* all data passed has been encoded */
> +        if (jret == JXL_ENC_SUCCESS)
> +            break;
> +        if (jret == JXL_ENC_NEED_MORE_OUTPUT) {

Is it possible for the encoder to return anything other than the three
codes you're handling? Won't you get into an infinite loop if it does?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".