Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v13 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl
Date: Mon, 11 Apr 2022 14:54:26 +0200
Message-ID: <164968166677.24258.14352669932965253932@lain.red.khirnov.net> (raw)
In-Reply-To: <CA+anqdwo16iTomSre_TvqR2LcGp2cZTkpjOGAWzKSYwc+2SuJQ@mail.gmail.com>

Quoting Hendrik Leppkes (2022-04-09 17:44:45)
> > >
> > > Also, pointers from av_malloc() cannot be passed to av_realloc(). You
> > > need to allocate it with av_realloc() in the first place.
> >
> > Is this documented? afaik realloc() can be used with malloc'd pointers.
> > It will, i assume, also realloc it the first time you call it even if
> > you request the exact same amount of memory malloc already allocated.
> > But in any case it's hardly a problem if he can just use av_realloc the
> > first time.
> 
> realloc can work with malloc, but thats not guaranteed with every form
> of aligned memory allocator.
> 
> That said, I don't think any platform where this is currently a
> problem is known, and we likely have this issue in a few areas of the
> code.
> The documentation of this limitation was removed in 2016
> (21f70940ae106bfffa07e73057cdb4b5e81a767a)

I remember this used to be an issue in the past. If it isn't anymore
then disregard my comment.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-04-11 12:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 16:55 [FFmpeg-devel] [PATCH v13 0/4] Jpeg XL Patch Set Leo Izen
2022-04-05 16:55 ` [FFmpeg-devel] [PATCH v13 1/4] avcodec/jpegxl: add Jpeg XL image codec Leo Izen
2022-04-05 16:55 ` [FFmpeg-devel] [PATCH v13 2/4] avcodec/libjxl: add Jpeg XL decoding via libjxl Leo Izen
2022-04-05 16:55 ` [FFmpeg-devel] [PATCH v13 3/4] avcodec/libjxl: add Jpeg XL encoding " Leo Izen
2022-04-09 13:17   ` Anton Khirnov
2022-04-09 15:37     ` James Almer
2022-04-09 15:44       ` Hendrik Leppkes
2022-04-11 12:54         ` Anton Khirnov [this message]
2022-04-11 11:16     ` Leo Izen
2022-04-11 12:52       ` Anton Khirnov
2022-04-05 16:55 ` [FFmpeg-devel] [PATCH v13 4/4] avformat/image2: add Jpeg XL as image2 format Leo Izen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164968166677.24258.14352669932965253932@lain.red.khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git