From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E162540C8E for ; Sat, 9 Apr 2022 13:17:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 49DA068B28B; Sat, 9 Apr 2022 16:17:44 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7AC6E68B28B for ; Sat, 9 Apr 2022 16:17:37 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id BE015240179; Sat, 9 Apr 2022 15:17:36 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id RD59lxWeKtjj; Sat, 9 Apr 2022 15:17:35 +0200 (CEST) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 688542400F5; Sat, 9 Apr 2022 15:17:35 +0200 (CEST) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 77E2B1601AD; Sat, 9 Apr 2022 15:17:32 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220405165504.29261-4-leo.izen@gmail.com> References: <20220405165504.29261-1-leo.izen@gmail.com> <20220405165504.29261-4-leo.izen@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches , Leo Izen Date: Sat, 09 Apr 2022 15:17:32 +0200 Message-ID: <164951025246.21047.6570158843618793411@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v13 3/4] avcodec/libjxl: add Jpeg XL encoding via libjxl X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Leo Izen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Leo Izen (2022-04-05 18:55:03) > +static int libjxl_init_jxl_encoder(AVCodecContext *avctx) > +{ > + LibJxlEncodeContext *ctx = avctx->priv_data; > + > + /* reset the encoder every frame for image2 muxer */ > + JxlEncoderReset(ctx->encoder); > + > + ctx->options = JxlEncoderFrameSettingsCreate(ctx->encoder, NULL); > + if (!ctx->options) { > + av_log(avctx, AV_LOG_ERROR, "Failed to create JxlEncoderOptions\n"); > + return AVERROR_EXTERNAL; > + } > + > + /* This needs to be set each time the decoder is reset */ > + if (JxlEncoderSetParallelRunner(ctx->encoder, JxlThreadParallelRunner, ctx->runner) > + != JXL_ENC_SUCCESS) { > + av_log(avctx, AV_LOG_ERROR, "Failed to set JxlThreadParallelRunner\n"); > + return AVERROR_EXTERNAL; > + } > + > + /* these shouldn't fail, libjxl bug notwithstanding */ > + if (JxlEncoderFrameSettingsSetOption(ctx->options, JXL_ENC_FRAME_SETTING_EFFORT, ctx->effort) > + != JXL_ENC_SUCCESS) { > + av_log(avctx, AV_LOG_ERROR, "Failed to set effort to: %d\n", ctx->effort); > + return AVERROR_EXTERNAL; > + } > + > + /* check for negative zero, our default */ > + if (1.0f / ctx->distance == 1.0f / -0.0f) { IIRC division by zero is UB. Why not make the default -1.0 and then just check whether the number is negative? > + /* > + * This buffer will be copied when the generic > + * code makes this packet refcounted, > + * so we can use the buffer again. > + */ > + pkt->data = ctx->buffer; > + pkt->size = bytes_written; This is very evil. Encoders should return refcounted packets and not rely on the generic code fixing stuff up for them. Also, pointers from av_malloc() cannot be passed to av_realloc(). You need to allocate it with av_realloc() in the first place. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".