* [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data
@ 2022-03-27 23:25 lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
` (5 more replies)
0 siblings, 6 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-27 23:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavutil/Makefile | 2 +
libavutil/ambient_viewing_env_metadata.c | 47 +++++++++++++++++++++
libavutil/ambient_viewing_env_metadata.h | 72 ++++++++++++++++++++++++++++++++
libavutil/frame.c | 1 +
libavutil/frame.h | 6 +++
5 files changed, 128 insertions(+)
create mode 100644 libavutil/ambient_viewing_env_metadata.c
create mode 100644 libavutil/ambient_viewing_env_metadata.h
diff --git a/libavutil/Makefile b/libavutil/Makefile
index 81df3b0..e388d33 100644
--- a/libavutil/Makefile
+++ b/libavutil/Makefile
@@ -26,6 +26,7 @@ HEADERS = adler32.h \
display.h \
dovi_meta.h \
downmix_info.h \
+ ambient_viewing_env_metadata.h \
encryption_info.h \
error.h \
eval.h \
@@ -119,6 +120,7 @@ OBJS = adler32.o \
display.o \
dovi_meta.o \
downmix_info.o \
+ ambient_viewing_env_metadata.o \
encryption_info.o \
error.o \
eval.o \
diff --git a/libavutil/ambient_viewing_env_metadata.c b/libavutil/ambient_viewing_env_metadata.c
new file mode 100644
index 0000000..7006b64
--- /dev/null
+++ b/libavutil/ambient_viewing_env_metadata.c
@@ -0,0 +1,47 @@
+/**
+ * Copyright (c) 2022 Limin Wang <lance.lmwang@gmail.com>
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include <stdint.h>
+#include <string.h>
+#include "ambient_viewing_env_metadata.h"
+#include "mem.h"
+
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
+{
+ AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
+
+ if (size)
+ *size = sizeof(*metadata);
+
+ return metadata;
+}
+
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
+{
+ AVFrameSideData *side_data = av_frame_new_side_data(frame,
+ AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
+ sizeof(AVAmbientViewingEnvMetadata));
+ if (!side_data)
+ return NULL;
+
+ memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
+
+ return (AVAmbientViewingEnvMetadata *)side_data->data;
+}
diff --git a/libavutil/ambient_viewing_env_metadata.h b/libavutil/ambient_viewing_env_metadata.h
new file mode 100644
index 0000000..b0fbcd0
--- /dev/null
+++ b/libavutil/ambient_viewing_env_metadata.h
@@ -0,0 +1,72 @@
+/*
+ * Copyright (c) 2022 Limin Wang <lance.lmwang@gmail.com>
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#ifndef AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H
+#define AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H
+
+#include "frame.h"
+
+
+/**
+ * The characteristics of the nominal ambient viewing environment for
+ * the display of the associated video content.
+ * To be used as payload of a AVFrameSideData the appropriate type.
+ *
+ * @note The struct should be allocated with av_ambient_viewing_env_metadata_alloc()
+ * and its size is not a part of the public ABI.
+ */
+typedef struct AVAmbientViewingEnvMetadata {
+ /**
+ * specifies the environmental illuminance of the ambient viewing
+ * environment in units of 0.0001 lux.
+ * ambient_illuminance shall not be equal to 0.
+ */
+ uint32_t ambient_illuminance;
+ /**
+ * specify the normalized x and y chromaticity coordinates, respectively,
+ * of the environmental ambient light in the nominal viewing environment,
+ * according to the CIE 1931 definition of x and y as specified in ISO
+ * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
+ * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
+ * the range of 0 to 50 000
+ */
+ uint16_t ambient_light_x;
+ uint16_t ambient_light_y;
+} AVAmbientViewingEnvMetadata;
+
+/**
+ * Allocate an AVAmbientViewingEnvMetadata structure and set its fields to
+ * default values. The resulting struct can be freed using av_freep().
+ *
+ * @return An AVAmbientViewingEnvMetadata filled with default values or NULL
+ * on failure.
+ */
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size);
+
+/**
+ * Allocate a complete AVAmbientViewingEnvMetadata and add it to the frame.
+ *
+ * @param frame The frame which side data is added to.
+ *
+ * @return The AVAmbientViewingEnvMetadata structure to be filled by caller.
+ */
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame);
+
+#endif /* AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H */
diff --git a/libavutil/frame.c b/libavutil/frame.c
index fbb869f..8882da2 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
+ case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
}
return NULL;
}
diff --git a/libavutil/frame.h b/libavutil/frame.h
index 33fac20..f7b1d4e 100644
--- a/libavutil/frame.h
+++ b/libavutil/frame.h
@@ -209,6 +209,12 @@ enum AVFrameSideDataType {
* volume transform - CUVA 005.1-2021.
*/
AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
+
+ /**
+ * ambient viewing environment for a video frame, as described by
+ * the AVAmbientViewingEnvMetadata.
+ */
+ AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
};
enum AVActiveFormatDescription {
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH 2/4] avcodec: add support for hevc ambient viewing environment SEI message
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
@ 2022-03-27 23:25 ` lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
` (4 subsequent siblings)
5 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-27 23:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavcodec/hevc_sei.c | 19 +++++++++++++++++++
libavcodec/hevc_sei.h | 8 ++++++++
libavcodec/hevcdec.c | 11 +++++++++++
tests/ref/fate/hevc-dv-rpu | 6 ++++++
4 files changed, 44 insertions(+)
diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
index ec3036f..d94df4e 100644
--- a/libavcodec/hevc_sei.c
+++ b/libavcodec/hevc_sei.c
@@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h,
return 0;
}
+static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size)
+{
+ if (size < 8)
+ return AVERROR_INVALIDDATA;
+
+ s->ambient_illuminance = get_bits(gb, 32);
+ s->ambient_light_x = get_bits(gb, 16);
+ s->ambient_light_y = get_bits(gb, 16);
+ size -= 8;
+
+ s->present = 1;
+
+ skip_bits_long(gb, 8 * size);
+ return 0;
+}
+
+
static int decode_nal_sei_prefix(GetBitContext *gb, void *logctx, HEVCSEI *s,
const HEVCParamSets *ps, int type, int size)
{
@@ -525,6 +542,8 @@ static int decode_nal_sei_prefix(GetBitContext *gb, void *logctx, HEVCSEI *s,
return decode_nal_sei_timecode(&s->timecode, gb);
case SEI_TYPE_FILM_GRAIN_CHARACTERISTICS:
return decode_film_grain_characteristics(&s->film_grain_characteristics, gb);
+ case SEI_TYPE_AMBIENT_VIEWING_ENVIRONMENT:
+ return decode_ambient_viewing_env(&s->ambient_viewing_env, gb, size);
default:
av_log(logctx, AV_LOG_DEBUG, "Skipped PREFIX SEI %d\n", type);
skip_bits_long(gb, 8 * size);
diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
index f198402..c7623f5 100644
--- a/libavcodec/hevc_sei.h
+++ b/libavcodec/hevc_sei.h
@@ -134,6 +134,13 @@ typedef struct HEVCSEIFilmGrainCharacteristics {
int persistence_flag;
} HEVCSEIFilmGrainCharacteristics;
+typedef struct HEVCSEIAmbientViewingEnvironment {
+ int present;
+ uint32_t ambient_illuminance;
+ uint16_t ambient_light_x;
+ uint16_t ambient_light_y;
+} HEVCSEIAmbientViewingEnvironment;
+
typedef struct HEVCSEI {
HEVCSEIPictureHash picture_hash;
HEVCSEIFramePacking frame_packing;
@@ -149,6 +156,7 @@ typedef struct HEVCSEI {
HEVCSEIAlternativeTransfer alternative_transfer;
HEVCSEITimeCode timecode;
HEVCSEIFilmGrainCharacteristics film_grain_characteristics;
+ HEVCSEIAmbientViewingEnvironment ambient_viewing_env;
} HEVCSEI;
struct HEVCParamSets;
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index 09c07ac..9be366e 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -36,6 +36,7 @@
#include "libavutil/pixdesc.h"
#include "libavutil/stereo3d.h"
#include "libavutil/timecode.h"
+#include "libavutil/ambient_viewing_env_metadata.h"
#include "bswapdsp.h"
#include "bytestream.h"
@@ -2998,6 +2999,15 @@ static int set_side_data(HEVCContext *s)
}
}
+ if (s->sei.ambient_viewing_env.present > 0) {
+ AVAmbientViewingEnvMetadata *metadata = av_ambient_viewing_env_metadata_create_side_data(out);
+ if (!metadata)
+ return AVERROR(ENOMEM);
+ metadata->ambient_illuminance = s->sei.ambient_viewing_env.ambient_illuminance;
+ metadata->ambient_light_x = s->sei.ambient_viewing_env.ambient_light_x;
+ metadata->ambient_light_y = s->sei.ambient_viewing_env.ambient_light_y;
+ }
+
return 0;
}
@@ -3800,6 +3810,7 @@ static int hevc_update_thread_context(AVCodecContext *dst,
s->sei.mastering_display = s0->sei.mastering_display;
s->sei.content_light = s0->sei.content_light;
s->sei.alternative_transfer = s0->sei.alternative_transfer;
+ s->sei.ambient_viewing_env = s0->sei.ambient_viewing_env;
ret = export_stream_params_from_sei(s);
if (ret < 0)
diff --git a/tests/ref/fate/hevc-dv-rpu b/tests/ref/fate/hevc-dv-rpu
index 1980ab1..6879f71 100644
--- a/tests/ref/fate/hevc-dv-rpu
+++ b/tests/ref/fate/hevc-dv-rpu
@@ -117,6 +117,9 @@ source_min_pq=0
source_max_pq=3079
source_diagonal=42
[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Ambient Viewing Environment
+[/SIDE_DATA]
[/FRAME]
[FRAME]
[SIDE_DATA]
@@ -234,4 +237,7 @@ source_min_pq=0
source_max_pq=3079
source_diagonal=42
[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Ambient Viewing Environment
+[/SIDE_DATA]
[/FRAME]
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
@ 2022-03-27 23:25 ` lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 4/4] fftools/ffprobe: " lance.lmwang
` (3 subsequent siblings)
5 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-27 23:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavfilter/vf_showinfo.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 12d3931..ad86251 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -42,6 +42,7 @@
#include "libavutil/mastering_display_metadata.h"
#include "libavutil/video_enc_params.h"
#include "libavutil/detection_bbox.h"
+#include "libavutil/ambient_viewing_env_metadata.h"
#include "avfilter.h"
#include "internal.h"
@@ -651,6 +652,15 @@ static void dump_color_property(AVFilterContext *ctx, AVFrame *frame)
av_log(ctx, AV_LOG_INFO, "\n");
}
+static void dump_ambient_viewing_env_metadata(AVFilterContext *ctx, AVFrameSideData *sd)
+{
+ const AVAmbientViewingEnvMetadata *metadata = (const AVAmbientViewingEnvMetadata *)sd->data;
+
+ av_log(ctx, AV_LOG_INFO, "Ambient Viewing Environment metadata: \n");
+ av_log(ctx, AV_LOG_INFO, " ambient_illuminance=%d, ambient_light_x=%d, ambient_light_y=%d",
+ metadata->ambient_illuminance, metadata->ambient_light_x, metadata->ambient_light_y);
+}
+
static void update_sample_stats_8(const uint8_t *src, int len, int64_t *sum, int64_t *sum2)
{
int i;
@@ -812,6 +822,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
case AV_FRAME_DATA_DOVI_METADATA:
dump_dovi_metadata(ctx, sd);
break;
+ case AV_FRAME_DATA_AMBIENT_VIEWING_ENV:
+ dump_ambient_viewing_env_metadata(ctx, sd);
+ break;
default:
av_log(ctx, AV_LOG_WARNING, "unknown side data type %d "
"(%"SIZE_SPECIFIER" bytes)\n", sd->type, sd->size);
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH 4/4] fftools/ffprobe: add support for ambient viewing environment metadata
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
@ 2022-03-27 23:25 ` lance.lmwang
2022-03-27 23:30 ` [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data James Almer
` (2 subsequent siblings)
5 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-27 23:25 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
fftools/ffprobe.c | 6 ++++++
tests/ref/fate/hevc-dv-rpu | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 05c167e..5abe496 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -52,6 +52,7 @@
#include "libavutil/parseutils.h"
#include "libavutil/timecode.h"
#include "libavutil/timestamp.h"
+#include "libavutil/ambient_viewing_env_metadata.h"
#include "libavdevice/avdevice.h"
#include "libavdevice/version.h"
#include "libswscale/swscale.h"
@@ -2605,6 +2606,11 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
AVContentLightMetadata *metadata = (AVContentLightMetadata *)sd->data;
print_int("max_content", metadata->MaxCLL);
print_int("max_average", metadata->MaxFALL);
+ } else if (sd->type == AV_FRAME_DATA_AMBIENT_VIEWING_ENV) {
+ AVAmbientViewingEnvMetadata *metadata = (AVAmbientViewingEnvMetadata *)sd->data;
+ print_int("ambient_illuminance", metadata->ambient_illuminance);
+ print_int("ambient_light_x", metadata->ambient_light_x);
+ print_int("ambient_light_y", metadata->ambient_light_y);
} else if (sd->type == AV_FRAME_DATA_ICC_PROFILE) {
const AVDictionaryEntry *tag = av_dict_get(sd->metadata, "name", NULL, AV_DICT_MATCH_CASE);
if (tag)
diff --git a/tests/ref/fate/hevc-dv-rpu b/tests/ref/fate/hevc-dv-rpu
index 6879f71..4ad5436 100644
--- a/tests/ref/fate/hevc-dv-rpu
+++ b/tests/ref/fate/hevc-dv-rpu
@@ -119,6 +119,9 @@ source_diagonal=42
[/SIDE_DATA]
[SIDE_DATA]
side_data_type=Ambient Viewing Environment
+ambient_illuminance=3140000
+ambient_light_x=15635
+ambient_light_y=16450
[/SIDE_DATA]
[/FRAME]
[FRAME]
@@ -239,5 +242,8 @@ source_diagonal=42
[/SIDE_DATA]
[SIDE_DATA]
side_data_type=Ambient Viewing Environment
+ambient_illuminance=3140000
+ambient_light_x=15635
+ambient_light_y=16450
[/SIDE_DATA]
[/FRAME]
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
` (2 preceding siblings ...)
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 4/4] fftools/ffprobe: " lance.lmwang
@ 2022-03-27 23:30 ` James Almer
2022-03-28 1:28 ` lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
5 siblings, 1 reply; 25+ messages in thread
From: James Almer @ 2022-03-27 23:30 UTC (permalink / raw)
To: ffmpeg-devel
On 3/27/2022 8:25 PM, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavutil/Makefile | 2 +
> libavutil/ambient_viewing_env_metadata.c | 47 +++++++++++++++++++++
> libavutil/ambient_viewing_env_metadata.h | 72 ++++++++++++++++++++++++++++++++
> libavutil/frame.c | 1 +
> libavutil/frame.h | 6 +++
> 5 files changed, 128 insertions(+)
> create mode 100644 libavutil/ambient_viewing_env_metadata.c
> create mode 100644 libavutil/ambient_viewing_env_metadata.h
>
> diff --git a/libavutil/Makefile b/libavutil/Makefile
> index 81df3b0..e388d33 100644
> --- a/libavutil/Makefile
> +++ b/libavutil/Makefile
> @@ -26,6 +26,7 @@ HEADERS = adler32.h \
> display.h \
> dovi_meta.h \
> downmix_info.h \
> + ambient_viewing_env_metadata.h \
> encryption_info.h \
> error.h \
> eval.h \
> @@ -119,6 +120,7 @@ OBJS = adler32.o \
> display.o \
> dovi_meta.o \
> downmix_info.o \
> + ambient_viewing_env_metadata.o \
> encryption_info.o \
> error.o \
> eval.o \
> diff --git a/libavutil/ambient_viewing_env_metadata.c b/libavutil/ambient_viewing_env_metadata.c
> new file mode 100644
> index 0000000..7006b64
> --- /dev/null
> +++ b/libavutil/ambient_viewing_env_metadata.c
> @@ -0,0 +1,47 @@
> +/**
> + * Copyright (c) 2022 Limin Wang <lance.lmwang@gmail.com>
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#include <stdint.h>
> +#include <string.h>
> +#include "ambient_viewing_env_metadata.h"
> +#include "mem.h"
> +
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
> +{
> + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
> +
> + if (size)
> + *size = sizeof(*metadata);
> +
> + return metadata;
> +}
> +
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
> +{
> + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> + sizeof(AVAmbientViewingEnvMetadata));
> + if (!side_data)
> + return NULL;
> +
> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
> +
> + return (AVAmbientViewingEnvMetadata *)side_data->data;
> +}
> diff --git a/libavutil/ambient_viewing_env_metadata.h b/libavutil/ambient_viewing_env_metadata.h
> new file mode 100644
> index 0000000..b0fbcd0
> --- /dev/null
> +++ b/libavutil/ambient_viewing_env_metadata.h
> @@ -0,0 +1,72 @@
> +/*
> + * Copyright (c) 2022 Limin Wang <lance.lmwang@gmail.com>
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +
> +#ifndef AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H
> +#define AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H
> +
> +#include "frame.h"
> +
> +
> +/**
> + * The characteristics of the nominal ambient viewing environment for
> + * the display of the associated video content.
> + * To be used as payload of a AVFrameSideData the appropriate type.
> + *
> + * @note The struct should be allocated with av_ambient_viewing_env_metadata_alloc()
> + * and its size is not a part of the public ABI.
> + */
> +typedef struct AVAmbientViewingEnvMetadata {
> + /**
> + * specifies the environmental illuminance of the ambient viewing
> + * environment in units of 0.0001 lux.
> + * ambient_illuminance shall not be equal to 0.
> + */
> + uint32_t ambient_illuminance;
> + /**
> + * specify the normalized x and y chromaticity coordinates, respectively,
> + * of the environmental ambient light in the nominal viewing environment,
> + * according to the CIE 1931 definition of x and y as specified in ISO
> + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
> + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
> + * the range of 0 to 50 000
> + */
> + uint16_t ambient_light_x;
> + uint16_t ambient_light_y;
> +} AVAmbientViewingEnvMetadata;
We don't need a new header for this. Just add it to
mastering_display_metadata.h. The other structs there are based on other
entries from the same spec (H.274) and have similar purposes.
> +
> +/**
> + * Allocate an AVAmbientViewingEnvMetadata structure and set its fields to
> + * default values. The resulting struct can be freed using av_freep().
> + *
> + * @return An AVAmbientViewingEnvMetadata filled with default values or NULL
> + * on failure.
> + */
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size);
> +
> +/**
> + * Allocate a complete AVAmbientViewingEnvMetadata and add it to the frame.
> + *
> + * @param frame The frame which side data is added to.
> + *
> + * @return The AVAmbientViewingEnvMetadata structure to be filled by caller.
> + */
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame);
> +
> +#endif /* AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H */
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index fbb869f..8882da2 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> }
> return NULL;
> }
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 33fac20..f7b1d4e 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> * volume transform - CUVA 005.1-2021.
> */
> AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> +
> + /**
> + * ambient viewing environment for a video frame, as described by
> + * the AVAmbientViewingEnvMetadata.
> + */
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> };
>
> enum AVActiveFormatDescription {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data
2022-03-27 23:30 ` [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data James Almer
@ 2022-03-28 1:28 ` lance.lmwang
0 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-28 1:28 UTC (permalink / raw)
To: ffmpeg-devel
On Sun, Mar 27, 2022 at 08:30:30PM -0300, James Almer wrote:
>
>
> On 3/27/2022 8:25 PM, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> > libavutil/Makefile | 2 +
> > libavutil/ambient_viewing_env_metadata.c | 47 +++++++++++++++++++++
> > libavutil/ambient_viewing_env_metadata.h | 72 ++++++++++++++++++++++++++++++++
> > libavutil/frame.c | 1 +
> > libavutil/frame.h | 6 +++
> > 5 files changed, 128 insertions(+)
> > create mode 100644 libavutil/ambient_viewing_env_metadata.c
> > create mode 100644 libavutil/ambient_viewing_env_metadata.h
> >
> > diff --git a/libavutil/Makefile b/libavutil/Makefile
> > index 81df3b0..e388d33 100644
> > --- a/libavutil/Makefile
> > +++ b/libavutil/Makefile
> > @@ -26,6 +26,7 @@ HEADERS = adler32.h \
> > display.h \
> > dovi_meta.h \
> > downmix_info.h \
> > + ambient_viewing_env_metadata.h \
> > encryption_info.h \
> > error.h \
> > eval.h \
> > @@ -119,6 +120,7 @@ OBJS = adler32.o \
> > display.o \
> > dovi_meta.o \
> > downmix_info.o \
> > + ambient_viewing_env_metadata.o \
> > encryption_info.o \
> > error.o \
> > eval.o \
> > diff --git a/libavutil/ambient_viewing_env_metadata.c b/libavutil/ambient_viewing_env_metadata.c
> > new file mode 100644
> > index 0000000..7006b64
> > --- /dev/null
> > +++ b/libavutil/ambient_viewing_env_metadata.c
> > @@ -0,0 +1,47 @@
> > +/**
> > + * Copyright (c) 2022 Limin Wang <lance.lmwang@gmail.com>
> > + *
> > + * This file is part of FFmpeg.
> > + *
> > + * FFmpeg is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2.1 of the License, or (at your option) any later version.
> > + *
> > + * FFmpeg is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + * Lesser General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with FFmpeg; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> > + */
> > +
> > +#include <stdint.h>
> > +#include <string.h>
> > +#include "ambient_viewing_env_metadata.h"
> > +#include "mem.h"
> > +
> > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
> > +{
> > + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
> > +
> > + if (size)
> > + *size = sizeof(*metadata);
> > +
> > + return metadata;
> > +}
> > +
> > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
> > +{
> > + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> > + sizeof(AVAmbientViewingEnvMetadata));
> > + if (!side_data)
> > + return NULL;
> > +
> > + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
> > +
> > + return (AVAmbientViewingEnvMetadata *)side_data->data;
> > +}
> > diff --git a/libavutil/ambient_viewing_env_metadata.h b/libavutil/ambient_viewing_env_metadata.h
> > new file mode 100644
> > index 0000000..b0fbcd0
> > --- /dev/null
> > +++ b/libavutil/ambient_viewing_env_metadata.h
> > @@ -0,0 +1,72 @@
> > +/*
> > + * Copyright (c) 2022 Limin Wang <lance.lmwang@gmail.com>
> > + *
> > + * This file is part of FFmpeg.
> > + *
> > + * FFmpeg is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU Lesser General Public
> > + * License as published by the Free Software Foundation; either
> > + * version 2.1 of the License, or (at your option) any later version.
> > + *
> > + * FFmpeg is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + * Lesser General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU Lesser General Public
> > + * License along with FFmpeg; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> > + */
> > +
> > +#ifndef AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H
> > +#define AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H
> > +
> > +#include "frame.h"
> > +
> > +
> > +/**
> > + * The characteristics of the nominal ambient viewing environment for
> > + * the display of the associated video content.
> > + * To be used as payload of a AVFrameSideData the appropriate type.
> > + *
> > + * @note The struct should be allocated with av_ambient_viewing_env_metadata_alloc()
> > + * and its size is not a part of the public ABI.
> > + */
> > +typedef struct AVAmbientViewingEnvMetadata {
> > + /**
> > + * specifies the environmental illuminance of the ambient viewing
> > + * environment in units of 0.0001 lux.
> > + * ambient_illuminance shall not be equal to 0.
> > + */
> > + uint32_t ambient_illuminance;
> > + /**
> > + * specify the normalized x and y chromaticity coordinates, respectively,
> > + * of the environmental ambient light in the nominal viewing environment,
> > + * according to the CIE 1931 definition of x and y as specified in ISO
> > + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
> > + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
> > + * the range of 0 to 50 000
> > + */
> > + uint16_t ambient_light_x;
> > + uint16_t ambient_light_y;
> > +} AVAmbientViewingEnvMetadata;
>
> We don't need a new header for this. Just add it to
> mastering_display_metadata.h. The other structs there are based on other
> entries from the same spec (H.274) and have similar purposes.
OK, will move to there as suggestion.
>
> > +
> > +/**
> > + * Allocate an AVAmbientViewingEnvMetadata structure and set its fields to
> > + * default values. The resulting struct can be freed using av_freep().
> > + *
> > + * @return An AVAmbientViewingEnvMetadata filled with default values or NULL
> > + * on failure.
> > + */
> > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size);
> > +
> > +/**
> > + * Allocate a complete AVAmbientViewingEnvMetadata and add it to the frame.
> > + *
> > + * @param frame The frame which side data is added to.
> > + *
> > + * @return The AVAmbientViewingEnvMetadata structure to be filled by caller.
> > + */
> > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame);
> > +
> > +#endif /* AVUTIL_AMBIENT_VIEWING_ENV_METADATA_H */
> > diff --git a/libavutil/frame.c b/libavutil/frame.c
> > index fbb869f..8882da2 100644
> > --- a/libavutil/frame.c
> > +++ b/libavutil/frame.c
> > @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> > case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> > case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> > case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> > + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> > }
> > return NULL;
> > }
> > diff --git a/libavutil/frame.h b/libavutil/frame.h
> > index 33fac20..f7b1d4e 100644
> > --- a/libavutil/frame.h
> > +++ b/libavutil/frame.h
> > @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> > * volume transform - CUVA 005.1-2021.
> > */
> > AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> > +
> > + /**
> > + * ambient viewing environment for a video frame, as described by
> > + * the AVAmbientViewingEnvMetadata.
> > + */
> > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> > };
> > enum AVActiveFormatDescription {
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
` (3 preceding siblings ...)
2022-03-27 23:30 ` [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data James Almer
@ 2022-03-28 12:41 ` lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
` (4 more replies)
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
5 siblings, 5 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-28 12:41 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavutil/frame.c | 1 +
libavutil/frame.h | 6 +++++
libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
4 files changed, 75 insertions(+)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index fbb869f..8882da2 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
+ case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
}
return NULL;
}
diff --git a/libavutil/frame.h b/libavutil/frame.h
index 33fac20..f7b1d4e 100644
--- a/libavutil/frame.h
+++ b/libavutil/frame.h
@@ -209,6 +209,12 @@ enum AVFrameSideDataType {
* volume transform - CUVA 005.1-2021.
*/
AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
+
+ /**
+ * ambient viewing environment for a video frame, as described by
+ * the AVAmbientViewingEnvMetadata.
+ */
+ AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
};
enum AVActiveFormatDescription {
diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
index 6069347..ba1c80f 100644
--- a/libavutil/mastering_display_metadata.c
+++ b/libavutil/mastering_display_metadata.c
@@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
return (AVContentLightMetadata *)side_data->data;
}
+
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
+{
+ AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
+
+ if (size)
+ *size = sizeof(*metadata);
+
+ return metadata;
+}
+
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
+{
+ AVFrameSideData *side_data = av_frame_new_side_data(frame,
+ AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
+ sizeof(AVAmbientViewingEnvMetadata));
+ if (!side_data)
+ return NULL;
+
+ memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
+
+ return (AVAmbientViewingEnvMetadata *)side_data->data;
+}
diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
index c23b07c..d7598c1 100644
--- a/libavutil/mastering_display_metadata.h
+++ b/libavutil/mastering_display_metadata.h
@@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
*/
AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
+/**
+ * The characteristics of the nominal ambient viewing environment for
+ * the display of the associated video content.
+ * To be used as payload of a AVFrameSideData the appropriate type.
+ *
+ * @note The struct should be allocated with av_ambient_viewing_env_metadata_alloc()
+ * and its size is not a part of the public ABI.
+ */
+typedef struct AVAmbientViewingEnvMetadata {
+ /**
+ * specifies the environmental illuminance of the ambient viewing
+ * environment in units of 0.0001 lux.
+ * ambient_illuminance shall not be equal to 0.
+ */
+ uint32_t ambient_illuminance;
+ /**
+ * specify the normalized x and y chromaticity coordinates, respectively,
+ * of the environmental ambient light in the nominal viewing environment,
+ * according to the CIE 1931 definition of x and y as specified in ISO
+ * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
+ * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
+ * the range of 0 to 50000
+ */
+ uint16_t ambient_light_x;
+ uint16_t ambient_light_y;
+} AVAmbientViewingEnvMetadata;
+
+/**
+ * Allocate an AVAmbientViewingEnvMetadata structure and set its fields to
+ * default values. The resulting struct can be freed using av_freep().
+ *
+ * @return An AVAmbientViewingEnvMetadata filled with default values or NULL
+ * on failure.
+ */
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size);
+
+/**
+ * Allocate a complete AVAmbientViewingEnvMetadata and add it to the frame.
+ *
+ * @param frame The frame which side data is added to.
+ *
+ * @return The AVAmbientViewingEnvMetadata structure to be filled by caller.
+ */
+AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame);
+
#endif /* AVUTIL_MASTERING_DISPLAY_METADATA_H */
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
@ 2022-03-28 12:41 ` lance.lmwang
2022-03-28 14:30 ` Michael Niedermayer
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
` (3 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: lance.lmwang @ 2022-03-28 12:41 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavcodec/hevc_sei.c | 19 +++++++++++++++++++
libavcodec/hevc_sei.h | 8 ++++++++
libavcodec/hevcdec.c | 10 ++++++++++
tests/ref/fate/hevc-dv-rpu | 6 ++++++
4 files changed, 43 insertions(+)
diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
index ec3036f..d94df4e 100644
--- a/libavcodec/hevc_sei.c
+++ b/libavcodec/hevc_sei.c
@@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h,
return 0;
}
+static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size)
+{
+ if (size < 8)
+ return AVERROR_INVALIDDATA;
+
+ s->ambient_illuminance = get_bits(gb, 32);
+ s->ambient_light_x = get_bits(gb, 16);
+ s->ambient_light_y = get_bits(gb, 16);
+ size -= 8;
+
+ s->present = 1;
+
+ skip_bits_long(gb, 8 * size);
+ return 0;
+}
+
+
static int decode_nal_sei_prefix(GetBitContext *gb, void *logctx, HEVCSEI *s,
const HEVCParamSets *ps, int type, int size)
{
@@ -525,6 +542,8 @@ static int decode_nal_sei_prefix(GetBitContext *gb, void *logctx, HEVCSEI *s,
return decode_nal_sei_timecode(&s->timecode, gb);
case SEI_TYPE_FILM_GRAIN_CHARACTERISTICS:
return decode_film_grain_characteristics(&s->film_grain_characteristics, gb);
+ case SEI_TYPE_AMBIENT_VIEWING_ENVIRONMENT:
+ return decode_ambient_viewing_env(&s->ambient_viewing_env, gb, size);
default:
av_log(logctx, AV_LOG_DEBUG, "Skipped PREFIX SEI %d\n", type);
skip_bits_long(gb, 8 * size);
diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
index f198402..c7623f5 100644
--- a/libavcodec/hevc_sei.h
+++ b/libavcodec/hevc_sei.h
@@ -134,6 +134,13 @@ typedef struct HEVCSEIFilmGrainCharacteristics {
int persistence_flag;
} HEVCSEIFilmGrainCharacteristics;
+typedef struct HEVCSEIAmbientViewingEnvironment {
+ int present;
+ uint32_t ambient_illuminance;
+ uint16_t ambient_light_x;
+ uint16_t ambient_light_y;
+} HEVCSEIAmbientViewingEnvironment;
+
typedef struct HEVCSEI {
HEVCSEIPictureHash picture_hash;
HEVCSEIFramePacking frame_packing;
@@ -149,6 +156,7 @@ typedef struct HEVCSEI {
HEVCSEIAlternativeTransfer alternative_transfer;
HEVCSEITimeCode timecode;
HEVCSEIFilmGrainCharacteristics film_grain_characteristics;
+ HEVCSEIAmbientViewingEnvironment ambient_viewing_env;
} HEVCSEI;
struct HEVCParamSets;
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index 09c07ac..13c6642 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -2998,6 +2998,15 @@ static int set_side_data(HEVCContext *s)
}
}
+ if (s->sei.ambient_viewing_env.present > 0) {
+ AVAmbientViewingEnvMetadata *metadata = av_ambient_viewing_env_metadata_create_side_data(out);
+ if (!metadata)
+ return AVERROR(ENOMEM);
+ metadata->ambient_illuminance = s->sei.ambient_viewing_env.ambient_illuminance;
+ metadata->ambient_light_x = s->sei.ambient_viewing_env.ambient_light_x;
+ metadata->ambient_light_y = s->sei.ambient_viewing_env.ambient_light_y;
+ }
+
return 0;
}
@@ -3800,6 +3809,7 @@ static int hevc_update_thread_context(AVCodecContext *dst,
s->sei.mastering_display = s0->sei.mastering_display;
s->sei.content_light = s0->sei.content_light;
s->sei.alternative_transfer = s0->sei.alternative_transfer;
+ s->sei.ambient_viewing_env = s0->sei.ambient_viewing_env;
ret = export_stream_params_from_sei(s);
if (ret < 0)
diff --git a/tests/ref/fate/hevc-dv-rpu b/tests/ref/fate/hevc-dv-rpu
index 1980ab1..6879f71 100644
--- a/tests/ref/fate/hevc-dv-rpu
+++ b/tests/ref/fate/hevc-dv-rpu
@@ -117,6 +117,9 @@ source_min_pq=0
source_max_pq=3079
source_diagonal=42
[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Ambient Viewing Environment
+[/SIDE_DATA]
[/FRAME]
[FRAME]
[SIDE_DATA]
@@ -234,4 +237,7 @@ source_min_pq=0
source_max_pq=3079
source_diagonal=42
[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Ambient Viewing Environment
+[/SIDE_DATA]
[/FRAME]
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v2 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
@ 2022-03-28 12:41 ` lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 4/4] fftools/ffprobe: " lance.lmwang
` (2 subsequent siblings)
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-28 12:41 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavfilter/vf_showinfo.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 12d3931..f11b3d9 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -651,6 +651,15 @@ static void dump_color_property(AVFilterContext *ctx, AVFrame *frame)
av_log(ctx, AV_LOG_INFO, "\n");
}
+static void dump_ambient_viewing_env_metadata(AVFilterContext *ctx, AVFrameSideData *sd)
+{
+ const AVAmbientViewingEnvMetadata *metadata = (const AVAmbientViewingEnvMetadata *)sd->data;
+
+ av_log(ctx, AV_LOG_INFO, "Ambient Viewing Environment metadata: \n");
+ av_log(ctx, AV_LOG_INFO, " ambient_illuminance=%d, ambient_light_x=%d, ambient_light_y=%d",
+ metadata->ambient_illuminance, metadata->ambient_light_x, metadata->ambient_light_y);
+}
+
static void update_sample_stats_8(const uint8_t *src, int len, int64_t *sum, int64_t *sum2)
{
int i;
@@ -812,6 +821,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
case AV_FRAME_DATA_DOVI_METADATA:
dump_dovi_metadata(ctx, sd);
break;
+ case AV_FRAME_DATA_AMBIENT_VIEWING_ENV:
+ dump_ambient_viewing_env_metadata(ctx, sd);
+ break;
default:
av_log(ctx, AV_LOG_WARNING, "unknown side data type %d "
"(%"SIZE_SPECIFIER" bytes)\n", sd->type, sd->size);
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v2 4/4] fftools/ffprobe: add support for ambient viewing environment metadata
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
@ 2022-03-28 12:41 ` lance.lmwang
2022-04-05 6:40 ` [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
2022-04-05 9:13 ` Anton Khirnov
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-28 12:41 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
fftools/ffprobe.c | 5 +++++
tests/ref/fate/hevc-dv-rpu | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 05c167e..39773c4 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2605,6 +2605,11 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
AVContentLightMetadata *metadata = (AVContentLightMetadata *)sd->data;
print_int("max_content", metadata->MaxCLL);
print_int("max_average", metadata->MaxFALL);
+ } else if (sd->type == AV_FRAME_DATA_AMBIENT_VIEWING_ENV) {
+ AVAmbientViewingEnvMetadata *metadata = (AVAmbientViewingEnvMetadata *)sd->data;
+ print_int("ambient_illuminance", metadata->ambient_illuminance);
+ print_int("ambient_light_x", metadata->ambient_light_x);
+ print_int("ambient_light_y", metadata->ambient_light_y);
} else if (sd->type == AV_FRAME_DATA_ICC_PROFILE) {
const AVDictionaryEntry *tag = av_dict_get(sd->metadata, "name", NULL, AV_DICT_MATCH_CASE);
if (tag)
diff --git a/tests/ref/fate/hevc-dv-rpu b/tests/ref/fate/hevc-dv-rpu
index 6879f71..4ad5436 100644
--- a/tests/ref/fate/hevc-dv-rpu
+++ b/tests/ref/fate/hevc-dv-rpu
@@ -119,6 +119,9 @@ source_diagonal=42
[/SIDE_DATA]
[SIDE_DATA]
side_data_type=Ambient Viewing Environment
+ambient_illuminance=3140000
+ambient_light_x=15635
+ambient_light_y=16450
[/SIDE_DATA]
[/FRAME]
[FRAME]
@@ -239,5 +242,8 @@ source_diagonal=42
[/SIDE_DATA]
[SIDE_DATA]
side_data_type=Ambient Viewing Environment
+ambient_illuminance=3140000
+ambient_light_x=15635
+ambient_light_y=16450
[/SIDE_DATA]
[/FRAME]
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
@ 2022-03-28 14:30 ` Michael Niedermayer
2022-03-28 23:09 ` lance.lmwang
0 siblings, 1 reply; 25+ messages in thread
From: Michael Niedermayer @ 2022-03-28 14:30 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 1198 bytes --]
On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavcodec/hevc_sei.c | 19 +++++++++++++++++++
> libavcodec/hevc_sei.h | 8 ++++++++
> libavcodec/hevcdec.c | 10 ++++++++++
> tests/ref/fate/hevc-dv-rpu | 6 ++++++
> 4 files changed, 43 insertions(+)
>
> diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
> index ec3036f..d94df4e 100644
> --- a/libavcodec/hevc_sei.c
> +++ b/libavcodec/hevc_sei.c
> @@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h,
> return 0;
> }
>
> +static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size)
> +{
> + if (size < 8)
> + return AVERROR_INVALIDDATA;
> +
> + s->ambient_illuminance = get_bits(gb, 32);
get_bits_long
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message
2022-03-28 14:30 ` Michael Niedermayer
@ 2022-03-28 23:09 ` lance.lmwang
0 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-03-28 23:09 UTC (permalink / raw)
To: ffmpeg-devel
On Mon, Mar 28, 2022 at 04:30:49PM +0200, Michael Niedermayer wrote:
> On Mon, Mar 28, 2022 at 08:41:09PM +0800, lance.lmwang@gmail.com wrote:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> > libavcodec/hevc_sei.c | 19 +++++++++++++++++++
> > libavcodec/hevc_sei.h | 8 ++++++++
> > libavcodec/hevcdec.c | 10 ++++++++++
> > tests/ref/fate/hevc-dv-rpu | 6 ++++++
> > 4 files changed, 43 insertions(+)
> >
> > diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
> > index ec3036f..d94df4e 100644
> > --- a/libavcodec/hevc_sei.c
> > +++ b/libavcodec/hevc_sei.c
> > @@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h,
> > return 0;
> > }
> >
> > +static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size)
> > +{
> > + if (size < 8)
> > + return AVERROR_INVALIDDATA;
> > +
> > + s->ambient_illuminance = get_bits(gb, 32);
>
> get_bits_long
thanks, fixed it locally.
>
> thx
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Its not that you shouldnt use gotos but rather that you should write
> readable code and code with gotos often but not always is less readable
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
` (2 preceding siblings ...)
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 4/4] fftools/ffprobe: " lance.lmwang
@ 2022-04-05 6:40 ` lance.lmwang
2022-04-05 9:13 ` Anton Khirnov
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 6:40 UTC (permalink / raw)
To: ffmpeg-devel
On Mon, Mar 28, 2022 at 08:41:08PM +0800, lance.lmwang@gmail.com wrote:
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavutil/frame.c | 1 +
> libavutil/frame.h | 6 +++++
> libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
> libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
> 4 files changed, 75 insertions(+)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index fbb869f..8882da2 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> }
> return NULL;
> }
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 33fac20..f7b1d4e 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> * volume transform - CUVA 005.1-2021.
> */
> AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> +
> + /**
> + * ambient viewing environment for a video frame, as described by
> + * the AVAmbientViewingEnvMetadata.
> + */
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> };
>
> enum AVActiveFormatDescription {
> diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
> index 6069347..ba1c80f 100644
> --- a/libavutil/mastering_display_metadata.c
> +++ b/libavutil/mastering_display_metadata.c
> @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
>
> return (AVContentLightMetadata *)side_data->data;
> }
> +
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
> +{
> + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
> +
> + if (size)
> + *size = sizeof(*metadata);
> +
> + return metadata;
> +}
> +
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
> +{
> + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> + sizeof(AVAmbientViewingEnvMetadata));
> + if (!side_data)
> + return NULL;
> +
> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
> +
> + return (AVAmbientViewingEnvMetadata *)side_data->data;
> +}
> diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
> index c23b07c..d7598c1 100644
> --- a/libavutil/mastering_display_metadata.h
> +++ b/libavutil/mastering_display_metadata.h
> @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
> */
> AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
>
> +/**
> + * The characteristics of the nominal ambient viewing environment for
> + * the display of the associated video content.
> + * To be used as payload of a AVFrameSideData the appropriate type.
> + *
> + * @note The struct should be allocated with av_ambient_viewing_env_metadata_alloc()
> + * and its size is not a part of the public ABI.
> + */
> +typedef struct AVAmbientViewingEnvMetadata {
> + /**
> + * specifies the environmental illuminance of the ambient viewing
> + * environment in units of 0.0001 lux.
> + * ambient_illuminance shall not be equal to 0.
> + */
> + uint32_t ambient_illuminance;
> + /**
> + * specify the normalized x and y chromaticity coordinates, respectively,
> + * of the environmental ambient light in the nominal viewing environment,
> + * according to the CIE 1931 definition of x and y as specified in ISO
> + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
> + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
> + * the range of 0 to 50000
> + */
> + uint16_t ambient_light_x;
> + uint16_t ambient_light_y;
> +} AVAmbientViewingEnvMetadata;
> +
> +/**
> + * Allocate an AVAmbientViewingEnvMetadata structure and set its fields to
> + * default values. The resulting struct can be freed using av_freep().
> + *
> + * @return An AVAmbientViewingEnvMetadata filled with default values or NULL
> + * on failure.
> + */
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size);
> +
> +/**
> + * Allocate a complete AVAmbientViewingEnvMetadata and add it to the frame.
> + *
> + * @param frame The frame which side data is added to.
> + *
> + * @return The AVAmbientViewingEnvMetadata structure to be filled by caller.
> + */
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame);
> +
> #endif /* AVUTIL_MASTERING_DISPLAY_METADATA_H */
> --
> 1.8.3.1
>
will apply the patch set(with bump version and one local fixed for
get_bits_long) tomorrow if no more comments.
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
` (3 preceding siblings ...)
2022-04-05 6:40 ` [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
@ 2022-04-05 9:13 ` Anton Khirnov
2022-04-05 9:24 ` lance.lmwang
4 siblings, 1 reply; 25+ messages in thread
From: Anton Khirnov @ 2022-04-05 9:13 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Limin Wang
Quoting lance.lmwang@gmail.com (2022-03-28 14:41:08)
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavutil/frame.c | 1 +
> libavutil/frame.h | 6 +++++
> libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
> libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
> 4 files changed, 75 insertions(+)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index fbb869f..8882da2 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> }
> return NULL;
> }
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 33fac20..f7b1d4e 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> * volume transform - CUVA 005.1-2021.
> */
> AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> +
> + /**
> + * ambient viewing environment for a video frame, as described by
> + * the AVAmbientViewingEnvMetadata.
> + */
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> };
>
> enum AVActiveFormatDescription {
> diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
> index 6069347..ba1c80f 100644
> --- a/libavutil/mastering_display_metadata.c
> +++ b/libavutil/mastering_display_metadata.c
> @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
>
> return (AVContentLightMetadata *)side_data->data;
> }
> +
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
> +{
> + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
> +
> + if (size)
> + *size = sizeof(*metadata);
> +
> + return metadata;
> +}
> +
> +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
> +{
> + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> + sizeof(AVAmbientViewingEnvMetadata));
> + if (!side_data)
> + return NULL;
> +
> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
> +
> + return (AVAmbientViewingEnvMetadata *)side_data->data;
> +}
> diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
> index c23b07c..d7598c1 100644
> --- a/libavutil/mastering_display_metadata.h
> +++ b/libavutil/mastering_display_metadata.h
> @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
> */
> AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
The names are horribly long. I would suggest dropping 'metadata' from
the struct and function names, they'd be shorter and no information is
really lost.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data
2022-04-05 9:13 ` Anton Khirnov
@ 2022-04-05 9:24 ` lance.lmwang
0 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 9:24 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, Apr 05, 2022 at 11:13:12AM +0200, Anton Khirnov wrote:
> Quoting lance.lmwang@gmail.com (2022-03-28 14:41:08)
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> > libavutil/frame.c | 1 +
> > libavutil/frame.h | 6 +++++
> > libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
> > libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
> > 4 files changed, 75 insertions(+)
> >
> > diff --git a/libavutil/frame.c b/libavutil/frame.c
> > index fbb869f..8882da2 100644
> > --- a/libavutil/frame.c
> > +++ b/libavutil/frame.c
> > @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> > case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> > case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> > case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> > + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> > }
> > return NULL;
> > }
> > diff --git a/libavutil/frame.h b/libavutil/frame.h
> > index 33fac20..f7b1d4e 100644
> > --- a/libavutil/frame.h
> > +++ b/libavutil/frame.h
> > @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> > * volume transform - CUVA 005.1-2021.
> > */
> > AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> > +
> > + /**
> > + * ambient viewing environment for a video frame, as described by
> > + * the AVAmbientViewingEnvMetadata.
> > + */
> > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> > };
> >
> > enum AVActiveFormatDescription {
> > diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
> > index 6069347..ba1c80f 100644
> > --- a/libavutil/mastering_display_metadata.c
> > +++ b/libavutil/mastering_display_metadata.c
> > @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
> >
> > return (AVContentLightMetadata *)side_data->data;
> > }
> > +
> > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_alloc(size_t *size)
> > +{
> > + AVAmbientViewingEnvMetadata *metadata = av_mallocz(sizeof(*metadata));
> > +
> > + if (size)
> > + *size = sizeof(*metadata);
> > +
> > + return metadata;
> > +}
> > +
> > +AVAmbientViewingEnvMetadata *av_ambient_viewing_env_metadata_create_side_data(AVFrame *frame)
> > +{
> > + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> > + sizeof(AVAmbientViewingEnvMetadata));
> > + if (!side_data)
> > + return NULL;
> > +
> > + memset(side_data->data, 0, sizeof(AVAmbientViewingEnvMetadata));
> > +
> > + return (AVAmbientViewingEnvMetadata *)side_data->data;
> > +}
> > diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
> > index c23b07c..d7598c1 100644
> > --- a/libavutil/mastering_display_metadata.h
> > +++ b/libavutil/mastering_display_metadata.h
> > @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
> > */
> > AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
>
> The names are horribly long. I would suggest dropping 'metadata' from
> the struct and function names, they'd be shorter and no information is
> really lost.
I'm OK with the suggestion, will update the patch, thanks.
>
> --
> Anton Khirnov
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
` (4 preceding siblings ...)
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
@ 2022-04-05 13:47 ` lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 2/5] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
` (4 more replies)
5 siblings, 5 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 13:47 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavutil/frame.c | 1 +
libavutil/frame.h | 6 +++++
libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
libavutil/version.h | 2 +-
5 files changed, 76 insertions(+), 1 deletion(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index fbb869f..8882da2 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
+ case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
}
return NULL;
}
diff --git a/libavutil/frame.h b/libavutil/frame.h
index 33fac20..92413c9 100644
--- a/libavutil/frame.h
+++ b/libavutil/frame.h
@@ -209,6 +209,12 @@ enum AVFrameSideDataType {
* volume transform - CUVA 005.1-2021.
*/
AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
+
+ /**
+ * ambient viewing environment for a video frame, as described by
+ * the AVAmbientViewingEnv
+ */
+ AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
};
enum AVActiveFormatDescription {
diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
index 6069347..f094eab 100644
--- a/libavutil/mastering_display_metadata.c
+++ b/libavutil/mastering_display_metadata.c
@@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
return (AVContentLightMetadata *)side_data->data;
}
+
+AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size)
+{
+ AVAmbientViewingEnv *metadata = av_mallocz(sizeof(*metadata));
+
+ if (size)
+ *size = sizeof(*metadata);
+
+ return metadata;
+}
+
+AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame)
+{
+ AVFrameSideData *side_data = av_frame_new_side_data(frame,
+ AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
+ sizeof(AVAmbientViewingEnv));
+ if (!side_data)
+ return NULL;
+
+ memset(side_data->data, 0, sizeof(AVAmbientViewingEnv));
+
+ return (AVAmbientViewingEnv *)side_data->data;
+}
diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
index c23b07c..c1ba659 100644
--- a/libavutil/mastering_display_metadata.h
+++ b/libavutil/mastering_display_metadata.h
@@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
*/
AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
+/**
+ * The characteristics of the nominal ambient viewing environment for
+ * the display of the associated video content.
+ * To be used as payload of a AVFrameSideData the appropriate type.
+ *
+ * @note The struct should be allocated with av_ambient_viewing_env_alloc()
+ * and its size is not a part of the public ABI.
+ */
+typedef struct AVAmbientViewingEnv {
+ /**
+ * specifies the environmental illuminance of the ambient viewing
+ * environment in units of 0.0001 lux.
+ * ambient_illuminance shall not be equal to 0.
+ */
+ uint32_t ambient_illuminance;
+ /**
+ * specify the normalized x and y chromaticity coordinates, respectively,
+ * of the environmental ambient light in the nominal viewing environment,
+ * according to the CIE 1931 definition of x and y as specified in ISO
+ * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
+ * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
+ * the range of 0 to 50000
+ */
+ uint16_t ambient_light_x;
+ uint16_t ambient_light_y;
+} AVAmbientViewingEnv;
+
+/**
+ * Allocate an AVAmbientViewingEnv structure and set its fields to
+ * default values. The resulting struct can be freed using av_freep().
+ *
+ * @return An AVAmbientViewingEnv filled with default values or NULL
+ * on failure.
+ */
+AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size);
+
+/**
+ * Allocate a complete AVAmbientViewingEnv and add it to the frame.
+ *
+ * @param frame The frame which side data is added to.
+ *
+ * @return The AVAmbientViewingEnv structure to be filled by caller.
+ */
+AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame);
+
#endif /* AVUTIL_MASTERING_DISPLAY_METADATA_H */
diff --git a/libavutil/version.h b/libavutil/version.h
index 6735c20..998202f 100644
--- a/libavutil/version.h
+++ b/libavutil/version.h
@@ -79,7 +79,7 @@
*/
#define LIBAVUTIL_VERSION_MAJOR 57
-#define LIBAVUTIL_VERSION_MINOR 24
+#define LIBAVUTIL_VERSION_MINOR 25
#define LIBAVUTIL_VERSION_MICRO 101
#define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v3 2/5] avcodec: add support for hevc ambient viewing environment SEI message
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
@ 2022-04-05 13:47 ` lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 3/5] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
` (3 subsequent siblings)
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 13:47 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavcodec/hevc_sei.c | 19 +++++++++++++++++++
libavcodec/hevc_sei.h | 8 ++++++++
libavcodec/hevcdec.c | 10 ++++++++++
tests/ref/fate/hevc-dv-rpu | 6 ++++++
4 files changed, 43 insertions(+)
diff --git a/libavcodec/hevc_sei.c b/libavcodec/hevc_sei.c
index ec3036f..8c6daf5 100644
--- a/libavcodec/hevc_sei.c
+++ b/libavcodec/hevc_sei.c
@@ -497,6 +497,23 @@ static int decode_film_grain_characteristics(HEVCSEIFilmGrainCharacteristics *h,
return 0;
}
+static int decode_ambient_viewing_env(HEVCSEIAmbientViewingEnvironment *s, GetBitContext *gb, int size)
+{
+ if (size < 8)
+ return AVERROR_INVALIDDATA;
+
+ s->ambient_illuminance = get_bits_long(gb, 32);
+ s->ambient_light_x = get_bits(gb, 16);
+ s->ambient_light_y = get_bits(gb, 16);
+ size -= 8;
+
+ s->present = 1;
+
+ skip_bits_long(gb, 8 * size);
+ return 0;
+}
+
+
static int decode_nal_sei_prefix(GetBitContext *gb, void *logctx, HEVCSEI *s,
const HEVCParamSets *ps, int type, int size)
{
@@ -525,6 +542,8 @@ static int decode_nal_sei_prefix(GetBitContext *gb, void *logctx, HEVCSEI *s,
return decode_nal_sei_timecode(&s->timecode, gb);
case SEI_TYPE_FILM_GRAIN_CHARACTERISTICS:
return decode_film_grain_characteristics(&s->film_grain_characteristics, gb);
+ case SEI_TYPE_AMBIENT_VIEWING_ENVIRONMENT:
+ return decode_ambient_viewing_env(&s->ambient_viewing_env, gb, size);
default:
av_log(logctx, AV_LOG_DEBUG, "Skipped PREFIX SEI %d\n", type);
skip_bits_long(gb, 8 * size);
diff --git a/libavcodec/hevc_sei.h b/libavcodec/hevc_sei.h
index f198402..c7623f5 100644
--- a/libavcodec/hevc_sei.h
+++ b/libavcodec/hevc_sei.h
@@ -134,6 +134,13 @@ typedef struct HEVCSEIFilmGrainCharacteristics {
int persistence_flag;
} HEVCSEIFilmGrainCharacteristics;
+typedef struct HEVCSEIAmbientViewingEnvironment {
+ int present;
+ uint32_t ambient_illuminance;
+ uint16_t ambient_light_x;
+ uint16_t ambient_light_y;
+} HEVCSEIAmbientViewingEnvironment;
+
typedef struct HEVCSEI {
HEVCSEIPictureHash picture_hash;
HEVCSEIFramePacking frame_packing;
@@ -149,6 +156,7 @@ typedef struct HEVCSEI {
HEVCSEIAlternativeTransfer alternative_transfer;
HEVCSEITimeCode timecode;
HEVCSEIFilmGrainCharacteristics film_grain_characteristics;
+ HEVCSEIAmbientViewingEnvironment ambient_viewing_env;
} HEVCSEI;
struct HEVCParamSets;
diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
index 09c07ac..21ed579 100644
--- a/libavcodec/hevcdec.c
+++ b/libavcodec/hevcdec.c
@@ -2998,6 +2998,15 @@ static int set_side_data(HEVCContext *s)
}
}
+ if (s->sei.ambient_viewing_env.present > 0) {
+ AVAmbientViewingEnv *metadata = av_ambient_viewing_env_create_side_data(out);
+ if (!metadata)
+ return AVERROR(ENOMEM);
+ metadata->ambient_illuminance = s->sei.ambient_viewing_env.ambient_illuminance;
+ metadata->ambient_light_x = s->sei.ambient_viewing_env.ambient_light_x;
+ metadata->ambient_light_y = s->sei.ambient_viewing_env.ambient_light_y;
+ }
+
return 0;
}
@@ -3800,6 +3809,7 @@ static int hevc_update_thread_context(AVCodecContext *dst,
s->sei.mastering_display = s0->sei.mastering_display;
s->sei.content_light = s0->sei.content_light;
s->sei.alternative_transfer = s0->sei.alternative_transfer;
+ s->sei.ambient_viewing_env = s0->sei.ambient_viewing_env;
ret = export_stream_params_from_sei(s);
if (ret < 0)
diff --git a/tests/ref/fate/hevc-dv-rpu b/tests/ref/fate/hevc-dv-rpu
index 1980ab1..6879f71 100644
--- a/tests/ref/fate/hevc-dv-rpu
+++ b/tests/ref/fate/hevc-dv-rpu
@@ -117,6 +117,9 @@ source_min_pq=0
source_max_pq=3079
source_diagonal=42
[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Ambient Viewing Environment
+[/SIDE_DATA]
[/FRAME]
[FRAME]
[SIDE_DATA]
@@ -234,4 +237,7 @@ source_min_pq=0
source_max_pq=3079
source_diagonal=42
[/SIDE_DATA]
+[SIDE_DATA]
+side_data_type=Ambient Viewing Environment
+[/SIDE_DATA]
[/FRAME]
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v3 3/5] avfilter/vf_showinfo: add support for ambient viewing environment metadata
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 2/5] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
@ 2022-04-05 13:47 ` lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 4/5] fftools/ffprobe: " lance.lmwang
` (2 subsequent siblings)
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 13:47 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavfilter/vf_showinfo.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 12d3931..1e81d26 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -651,6 +651,15 @@ static void dump_color_property(AVFilterContext *ctx, AVFrame *frame)
av_log(ctx, AV_LOG_INFO, "\n");
}
+static void dump_ambient_viewing_env(AVFilterContext *ctx, AVFrameSideData *sd)
+{
+ const AVAmbientViewingEnv *metadata = (const AVAmbientViewingEnv *)sd->data;
+
+ av_log(ctx, AV_LOG_INFO, "Ambient Viewing Environment: \n");
+ av_log(ctx, AV_LOG_INFO, " ambient_illuminance=%d, ambient_light_x=%d, ambient_light_y=%d",
+ metadata->ambient_illuminance, metadata->ambient_light_x, metadata->ambient_light_y);
+}
+
static void update_sample_stats_8(const uint8_t *src, int len, int64_t *sum, int64_t *sum2)
{
int i;
@@ -812,6 +821,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
case AV_FRAME_DATA_DOVI_METADATA:
dump_dovi_metadata(ctx, sd);
break;
+ case AV_FRAME_DATA_AMBIENT_VIEWING_ENV:
+ dump_ambient_viewing_env(ctx, sd);
+ break;
default:
av_log(ctx, AV_LOG_WARNING, "unknown side data type %d "
"(%"SIZE_SPECIFIER" bytes)\n", sd->type, sd->size);
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v3 4/5] fftools/ffprobe: add support for ambient viewing environment metadata
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 2/5] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 3/5] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
@ 2022-04-05 13:47 ` lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 5/5] avfilter/vf_showinfo: fix unknown side data type for DOVI_RPU_BUFFER lance.lmwang
2022-04-05 15:32 ` [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data Andreas Rheinhardt
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 13:47 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
fftools/ffprobe.c | 5 +++++
tests/ref/fate/hevc-dv-rpu | 6 ++++++
2 files changed, 11 insertions(+)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index 05c167e..a13b93e 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -2605,6 +2605,11 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
AVContentLightMetadata *metadata = (AVContentLightMetadata *)sd->data;
print_int("max_content", metadata->MaxCLL);
print_int("max_average", metadata->MaxFALL);
+ } else if (sd->type == AV_FRAME_DATA_AMBIENT_VIEWING_ENV) {
+ AVAmbientViewingEnv *metadata = (AVAmbientViewingEnv *)sd->data;
+ print_int("ambient_illuminance", metadata->ambient_illuminance);
+ print_int("ambient_light_x", metadata->ambient_light_x);
+ print_int("ambient_light_y", metadata->ambient_light_y);
} else if (sd->type == AV_FRAME_DATA_ICC_PROFILE) {
const AVDictionaryEntry *tag = av_dict_get(sd->metadata, "name", NULL, AV_DICT_MATCH_CASE);
if (tag)
diff --git a/tests/ref/fate/hevc-dv-rpu b/tests/ref/fate/hevc-dv-rpu
index 6879f71..4ad5436 100644
--- a/tests/ref/fate/hevc-dv-rpu
+++ b/tests/ref/fate/hevc-dv-rpu
@@ -119,6 +119,9 @@ source_diagonal=42
[/SIDE_DATA]
[SIDE_DATA]
side_data_type=Ambient Viewing Environment
+ambient_illuminance=3140000
+ambient_light_x=15635
+ambient_light_y=16450
[/SIDE_DATA]
[/FRAME]
[FRAME]
@@ -239,5 +242,8 @@ source_diagonal=42
[/SIDE_DATA]
[SIDE_DATA]
side_data_type=Ambient Viewing Environment
+ambient_illuminance=3140000
+ambient_light_x=15635
+ambient_light_y=16450
[/SIDE_DATA]
[/FRAME]
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* [FFmpeg-devel] [PATCH v3 5/5] avfilter/vf_showinfo: fix unknown side data type for DOVI_RPU_BUFFER
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
` (2 preceding siblings ...)
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 4/5] fftools/ffprobe: " lance.lmwang
@ 2022-04-05 13:47 ` lance.lmwang
2022-04-05 15:32 ` [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data Andreas Rheinhardt
4 siblings, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 13:47 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Limin Wang
From: Limin Wang <lance.lmwang@gmail.com>
Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
---
libavfilter/vf_showinfo.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c
index 1e81d26..18ddf12 100644
--- a/libavfilter/vf_showinfo.c
+++ b/libavfilter/vf_showinfo.c
@@ -824,6 +824,10 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
case AV_FRAME_DATA_AMBIENT_VIEWING_ENV:
dump_ambient_viewing_env(ctx, sd);
break;
+ case AV_FRAME_DATA_DOVI_RPU_BUFFER:
+ av_log(ctx, AV_LOG_INFO, "DOVI RPU raw data "
+ "(%"SIZE_SPECIFIER" bytes)", sd->size);
+ break;
default:
av_log(ctx, AV_LOG_WARNING, "unknown side data type %d "
"(%"SIZE_SPECIFIER" bytes)\n", sd->type, sd->size);
--
1.8.3.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
` (3 preceding siblings ...)
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 5/5] avfilter/vf_showinfo: fix unknown side data type for DOVI_RPU_BUFFER lance.lmwang
@ 2022-04-05 15:32 ` Andreas Rheinhardt
2022-04-05 19:00 ` Lynne
2022-04-05 23:11 ` lance.lmwang
4 siblings, 2 replies; 25+ messages in thread
From: Andreas Rheinhardt @ 2022-04-05 15:32 UTC (permalink / raw)
To: ffmpeg-devel
lance.lmwang@gmail.com:
> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavutil/frame.c | 1 +
> libavutil/frame.h | 6 +++++
> libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
> libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
> libavutil/version.h | 2 +-
> 5 files changed, 76 insertions(+), 1 deletion(-)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index fbb869f..8882da2 100644
> --- a/libavutil/frame.c
> +++ b/libavutil/frame.c
> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> }
> return NULL;
> }
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index 33fac20..92413c9 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> * volume transform - CUVA 005.1-2021.
> */
> AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> +
> + /**
> + * ambient viewing environment for a video frame, as described by
> + * the AVAmbientViewingEnv
> + */
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> };
>
> enum AVActiveFormatDescription {
> diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
> index 6069347..f094eab 100644
> --- a/libavutil/mastering_display_metadata.c
> +++ b/libavutil/mastering_display_metadata.c
> @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
>
> return (AVContentLightMetadata *)side_data->data;
> }
> +
> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size)
> +{
> + AVAmbientViewingEnv *metadata = av_mallocz(sizeof(*metadata));
> +
> + if (size)
> + *size = sizeof(*metadata);
> +
> + return metadata;
> +}
> +
> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame)
> +{
> + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> + sizeof(AVAmbientViewingEnv));
> + if (!side_data)
> + return NULL;
> +
> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnv));
> +
> + return (AVAmbientViewingEnv *)side_data->data;
> +}
> diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
> index c23b07c..c1ba659 100644
> --- a/libavutil/mastering_display_metadata.h
> +++ b/libavutil/mastering_display_metadata.h
> @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
> */
> AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
>
> +/**
> + * The characteristics of the nominal ambient viewing environment for
> + * the display of the associated video content.
> + * To be used as payload of a AVFrameSideData the appropriate type.
> + *
> + * @note The struct should be allocated with av_ambient_viewing_env_alloc()
> + * and its size is not a part of the public ABI.
> + */
> +typedef struct AVAmbientViewingEnv {
> + /**
> + * specifies the environmental illuminance of the ambient viewing
> + * environment in units of 0.0001 lux.
> + * ambient_illuminance shall not be equal to 0.
> + */
> + uint32_t ambient_illuminance;
> + /**
> + * specify the normalized x and y chromaticity coordinates, respectively,
> + * of the environmental ambient light in the nominal viewing environment,
> + * according to the CIE 1931 definition of x and y as specified in ISO
> + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
> + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
> + * the range of 0 to 50000
> + */
> + uint16_t ambient_light_x;
> + uint16_t ambient_light_y;
> +} AVAmbientViewingEnv;
> +
> +/**
> + * Allocate an AVAmbientViewingEnv structure and set its fields to
> + * default values. The resulting struct can be freed using av_freep().
> + *
> + * @return An AVAmbientViewingEnv filled with default values or NULL
> + * on failure.
> + */
> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size);
> +
> +/**
> + * Allocate a complete AVAmbientViewingEnv and add it to the frame.
> + *
> + * @param frame The frame which side data is added to.
> + *
> + * @return The AVAmbientViewingEnv structure to be filled by caller.
> + */
> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame);
All this boilerplate code for the various side-data--types makes me
wonder whether they should not be replaced by something like
void *av_frame_side_data_alloc(enum AVFrameSideDataType, size_t *size)
and a corresponding av_frame_create_side_data(AVFrame *frame, enum
AVFrameSideDataType).
These functions would return an error in case it doesn't make sense to
create a side data this way (because there is no struct associated to
this side data type or because the size of this struct depends upon
other parameters, too).
> +
> #endif /* AVUTIL_MASTERING_DISPLAY_METADATA_H */
> diff --git a/libavutil/version.h b/libavutil/version.h
> index 6735c20..998202f 100644
> --- a/libavutil/version.h
> +++ b/libavutil/version.h
> @@ -79,7 +79,7 @@
> */
>
> #define LIBAVUTIL_VERSION_MAJOR 57
> -#define LIBAVUTIL_VERSION_MINOR 24
> +#define LIBAVUTIL_VERSION_MINOR 25
> #define LIBAVUTIL_VERSION_MICRO 101
Micro needs to be reset when minor is bumped.
>
> #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data
2022-04-05 15:32 ` [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data Andreas Rheinhardt
@ 2022-04-05 19:00 ` Lynne
2022-04-05 19:13 ` Anton Khirnov
2022-04-05 19:42 ` Andreas Rheinhardt
2022-04-05 23:11 ` lance.lmwang
1 sibling, 2 replies; 25+ messages in thread
From: Lynne @ 2022-04-05 19:00 UTC (permalink / raw)
To: FFmpeg development discussions and patches
5 Apr 2022, 17:32 by andreas.rheinhardt@outlook.com:
> lance.lmwang@gmail.com:
>
>> From: Limin Wang <lance.lmwang@gmail.com>
>>
>> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>> ---
>> libavutil/frame.c | 1 +
>> libavutil/frame.h | 6 +++++
>> libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
>> libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
>> libavutil/version.h | 2 +-
>> 5 files changed, 76 insertions(+), 1 deletion(-)
>>
>> diff --git a/libavutil/frame.c b/libavutil/frame.c
>> index fbb869f..8882da2 100644
>> --- a/libavutil/frame.c
>> +++ b/libavutil/frame.c
>> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
>> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
>> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
>> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
>> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
>> }
>> return NULL;
>> }
>> diff --git a/libavutil/frame.h b/libavutil/frame.h
>> index 33fac20..92413c9 100644
>> --- a/libavutil/frame.h
>> +++ b/libavutil/frame.h
>> @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
>> * volume transform - CUVA 005.1-2021.
>> */
>> AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
>> +
>> + /**
>> + * ambient viewing environment for a video frame, as described by
>> + * the AVAmbientViewingEnv
>> + */
>> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
>> };
>>
>> enum AVActiveFormatDescription {
>> diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
>> index 6069347..f094eab 100644
>> --- a/libavutil/mastering_display_metadata.c
>> +++ b/libavutil/mastering_display_metadata.c
>> @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
>>
>> return (AVContentLightMetadata *)side_data->data;
>> }
>> +
>> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size)
>> +{
>> + AVAmbientViewingEnv *metadata = av_mallocz(sizeof(*metadata));
>> +
>> + if (size)
>> + *size = sizeof(*metadata);
>> +
>> + return metadata;
>> +}
>> +
>> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame)
>> +{
>> + AVFrameSideData *side_data = av_frame_new_side_data(frame,
>> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
>> + sizeof(AVAmbientViewingEnv));
>> + if (!side_data)
>> + return NULL;
>> +
>> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnv));
>> +
>> + return (AVAmbientViewingEnv *)side_data->data;
>> +}
>> diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
>> index c23b07c..c1ba659 100644
>> --- a/libavutil/mastering_display_metadata.h
>> +++ b/libavutil/mastering_display_metadata.h
>> @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
>> */
>> AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
>>
>> +/**
>> + * The characteristics of the nominal ambient viewing environment for
>> + * the display of the associated video content.
>> + * To be used as payload of a AVFrameSideData the appropriate type.
>> + *
>> + * @note The struct should be allocated with av_ambient_viewing_env_alloc()
>> + * and its size is not a part of the public ABI.
>> + */
>> +typedef struct AVAmbientViewingEnv {
>> + /**
>> + * specifies the environmental illuminance of the ambient viewing
>> + * environment in units of 0.0001 lux.
>> + * ambient_illuminance shall not be equal to 0.
>> + */
>> + uint32_t ambient_illuminance;
>> + /**
>> + * specify the normalized x and y chromaticity coordinates, respectively,
>> + * of the environmental ambient light in the nominal viewing environment,
>> + * according to the CIE 1931 definition of x and y as specified in ISO
>> + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
>> + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
>> + * the range of 0 to 50000
>> + */
>> + uint16_t ambient_light_x;
>> + uint16_t ambient_light_y;
>> +} AVAmbientViewingEnv;
>> +
>> +/**
>> + * Allocate an AVAmbientViewingEnv structure and set its fields to
>> + * default values. The resulting struct can be freed using av_freep().
>> + *
>> + * @return An AVAmbientViewingEnv filled with default values or NULL
>> + * on failure.
>> + */
>> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size);
>> +
>> +/**
>> + * Allocate a complete AVAmbientViewingEnv and add it to the frame.
>> + *
>> + * @param frame The frame which side data is added to.
>> + *
>> + * @return The AVAmbientViewingEnv structure to be filled by caller.
>> + */
>> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame);
>>
>
> All this boilerplate code for the various side-data--types makes me
> wonder whether they should not be replaced by something like
> void *av_frame_side_data_alloc(enum AVFrameSideDataType, size_t *size)
> and a corresponding av_frame_create_side_data(AVFrame *frame, enum
> AVFrameSideDataType).
> These functions would return an error in case it doesn't make sense to
> create a side data this way (because there is no struct associated to
> this side data type or because the size of this struct depends upon
> other parameters, too).
>
Why is this side data type allocated, rather than what used to be
the standard, making the side data struct size const? Copy-paste?
Are new fields expected to be added in the future? HDR mastering
metadata is also allocated, but we've never added any fields since
it was merged.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data
2022-04-05 19:00 ` Lynne
@ 2022-04-05 19:13 ` Anton Khirnov
2022-04-05 19:42 ` Andreas Rheinhardt
1 sibling, 0 replies; 25+ messages in thread
From: Anton Khirnov @ 2022-04-05 19:13 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Quoting Lynne (2022-04-05 21:00:24)
> 5 Apr 2022, 17:32 by andreas.rheinhardt@outlook.com:
> Why is this side data type allocated, rather than what used to be
> the standard, making the side data struct size const? Copy-paste?
>
> Are new fields expected to be added in the future? HDR mastering
> metadata is also allocated, but we've never added any fields since
> it was merged.
Better to have the option and not use it than the converse.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data
2022-04-05 19:00 ` Lynne
2022-04-05 19:13 ` Anton Khirnov
@ 2022-04-05 19:42 ` Andreas Rheinhardt
1 sibling, 0 replies; 25+ messages in thread
From: Andreas Rheinhardt @ 2022-04-05 19:42 UTC (permalink / raw)
To: ffmpeg-devel
Lynne:
> 5 Apr 2022, 17:32 by andreas.rheinhardt@outlook.com:
>
>> lance.lmwang@gmail.com:
>>
>>> From: Limin Wang <lance.lmwang@gmail.com>
>>>
>>> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
>>> ---
>>> libavutil/frame.c | 1 +
>>> libavutil/frame.h | 6 +++++
>>> libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
>>> libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
>>> libavutil/version.h | 2 +-
>>> 5 files changed, 76 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/libavutil/frame.c b/libavutil/frame.c
>>> index fbb869f..8882da2 100644
>>> --- a/libavutil/frame.c
>>> +++ b/libavutil/frame.c
>>> @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
>>> case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
>>> case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
>>> case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
>>> + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
>>> }
>>> return NULL;
>>> }
>>> diff --git a/libavutil/frame.h b/libavutil/frame.h
>>> index 33fac20..92413c9 100644
>>> --- a/libavutil/frame.h
>>> +++ b/libavutil/frame.h
>>> @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
>>> * volume transform - CUVA 005.1-2021.
>>> */
>>> AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
>>> +
>>> + /**
>>> + * ambient viewing environment for a video frame, as described by
>>> + * the AVAmbientViewingEnv
>>> + */
>>> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
>>> };
>>>
>>> enum AVActiveFormatDescription {
>>> diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
>>> index 6069347..f094eab 100644
>>> --- a/libavutil/mastering_display_metadata.c
>>> +++ b/libavutil/mastering_display_metadata.c
>>> @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
>>>
>>> return (AVContentLightMetadata *)side_data->data;
>>> }
>>> +
>>> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size)
>>> +{
>>> + AVAmbientViewingEnv *metadata = av_mallocz(sizeof(*metadata));
>>> +
>>> + if (size)
>>> + *size = sizeof(*metadata);
>>> +
>>> + return metadata;
>>> +}
>>> +
>>> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame)
>>> +{
>>> + AVFrameSideData *side_data = av_frame_new_side_data(frame,
>>> + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
>>> + sizeof(AVAmbientViewingEnv));
>>> + if (!side_data)
>>> + return NULL;
>>> +
>>> + memset(side_data->data, 0, sizeof(AVAmbientViewingEnv));
>>> +
>>> + return (AVAmbientViewingEnv *)side_data->data;
>>> +}
>>> diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
>>> index c23b07c..c1ba659 100644
>>> --- a/libavutil/mastering_display_metadata.h
>>> +++ b/libavutil/mastering_display_metadata.h
>>> @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
>>> */
>>> AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
>>>
>>> +/**
>>> + * The characteristics of the nominal ambient viewing environment for
>>> + * the display of the associated video content.
>>> + * To be used as payload of a AVFrameSideData the appropriate type.
>>> + *
>>> + * @note The struct should be allocated with av_ambient_viewing_env_alloc()
>>> + * and its size is not a part of the public ABI.
>>> + */
>>> +typedef struct AVAmbientViewingEnv {
>>> + /**
>>> + * specifies the environmental illuminance of the ambient viewing
>>> + * environment in units of 0.0001 lux.
>>> + * ambient_illuminance shall not be equal to 0.
>>> + */
>>> + uint32_t ambient_illuminance;
>>> + /**
>>> + * specify the normalized x and y chromaticity coordinates, respectively,
>>> + * of the environmental ambient light in the nominal viewing environment,
>>> + * according to the CIE 1931 definition of x and y as specified in ISO
>>> + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
>>> + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
>>> + * the range of 0 to 50000
>>> + */
>>> + uint16_t ambient_light_x;
>>> + uint16_t ambient_light_y;
>>> +} AVAmbientViewingEnv;
>>> +
>>> +/**
>>> + * Allocate an AVAmbientViewingEnv structure and set its fields to
>>> + * default values. The resulting struct can be freed using av_freep().
>>> + *
>>> + * @return An AVAmbientViewingEnv filled with default values or NULL
>>> + * on failure.
>>> + */
>>> +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size);
>>> +
>>> +/**
>>> + * Allocate a complete AVAmbientViewingEnv and add it to the frame.
>>> + *
>>> + * @param frame The frame which side data is added to.
>>> + *
>>> + * @return The AVAmbientViewingEnv structure to be filled by caller.
>>> + */
>>> +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame);
>>>
>>
>> All this boilerplate code for the various side-data--types makes me
>> wonder whether they should not be replaced by something like
>> void *av_frame_side_data_alloc(enum AVFrameSideDataType, size_t *size)
>> and a corresponding av_frame_create_side_data(AVFrame *frame, enum
>> AVFrameSideDataType).
>> These functions would return an error in case it doesn't make sense to
>> create a side data this way (because there is no struct associated to
>> this side data type or because the size of this struct depends upon
>> other parameters, too).
>>
>
> Why is this side data type allocated, rather than what used to be
> the standard, making the side data struct size const? Copy-paste?
>
> Are new fields expected to be added in the future? HDR mastering
> metadata is also allocated, but we've never added any fields since
> it was merged.
With "const" you mean make the size part of the ABI? Well, given that
side-data is always allocated, it doesn't really hurt to make the size
of these fields not part of the ABI.
(There are cases where this is not so: sizeof(AVBufferRef) not being
part of the public ABI means that every av_buffer_ref() has an
allocation and therefore needs to be checked. No addition to AVBufferRef
has ever been made.)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data
2022-04-05 15:32 ` [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data Andreas Rheinhardt
2022-04-05 19:00 ` Lynne
@ 2022-04-05 23:11 ` lance.lmwang
1 sibling, 0 replies; 25+ messages in thread
From: lance.lmwang @ 2022-04-05 23:11 UTC (permalink / raw)
To: ffmpeg-devel
On Tue, Apr 05, 2022 at 05:32:12PM +0200, Andreas Rheinhardt wrote:
> lance.lmwang@gmail.com:
> > From: Limin Wang <lance.lmwang@gmail.com>
> >
> > Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> > ---
> > libavutil/frame.c | 1 +
> > libavutil/frame.h | 6 +++++
> > libavutil/mastering_display_metadata.c | 23 +++++++++++++++++
> > libavutil/mastering_display_metadata.h | 45 ++++++++++++++++++++++++++++++++++
> > libavutil/version.h | 2 +-
> > 5 files changed, 76 insertions(+), 1 deletion(-)
> >
> > diff --git a/libavutil/frame.c b/libavutil/frame.c
> > index fbb869f..8882da2 100644
> > --- a/libavutil/frame.c
> > +++ b/libavutil/frame.c
> > @@ -815,6 +815,7 @@ const char *av_frame_side_data_name(enum AVFrameSideDataType type)
> > case AV_FRAME_DATA_DETECTION_BBOXES: return "Bounding boxes for object detection and classification";
> > case AV_FRAME_DATA_DOVI_RPU_BUFFER: return "Dolby Vision RPU Data";
> > case AV_FRAME_DATA_DOVI_METADATA: return "Dolby Vision Metadata";
> > + case AV_FRAME_DATA_AMBIENT_VIEWING_ENV: return "Ambient Viewing Environment";
> > }
> > return NULL;
> > }
> > diff --git a/libavutil/frame.h b/libavutil/frame.h
> > index 33fac20..92413c9 100644
> > --- a/libavutil/frame.h
> > +++ b/libavutil/frame.h
> > @@ -209,6 +209,12 @@ enum AVFrameSideDataType {
> > * volume transform - CUVA 005.1-2021.
> > */
> > AV_FRAME_DATA_DYNAMIC_HDR_VIVID,
> > +
> > + /**
> > + * ambient viewing environment for a video frame, as described by
> > + * the AVAmbientViewingEnv
> > + */
> > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> > };
> >
> > enum AVActiveFormatDescription {
> > diff --git a/libavutil/mastering_display_metadata.c b/libavutil/mastering_display_metadata.c
> > index 6069347..f094eab 100644
> > --- a/libavutil/mastering_display_metadata.c
> > +++ b/libavutil/mastering_display_metadata.c
> > @@ -64,3 +64,26 @@ AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *fram
> >
> > return (AVContentLightMetadata *)side_data->data;
> > }
> > +
> > +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size)
> > +{
> > + AVAmbientViewingEnv *metadata = av_mallocz(sizeof(*metadata));
> > +
> > + if (size)
> > + *size = sizeof(*metadata);
> > +
> > + return metadata;
> > +}
> > +
> > +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame)
> > +{
> > + AVFrameSideData *side_data = av_frame_new_side_data(frame,
> > + AV_FRAME_DATA_AMBIENT_VIEWING_ENV,
> > + sizeof(AVAmbientViewingEnv));
> > + if (!side_data)
> > + return NULL;
> > +
> > + memset(side_data->data, 0, sizeof(AVAmbientViewingEnv));
> > +
> > + return (AVAmbientViewingEnv *)side_data->data;
> > +}
> > diff --git a/libavutil/mastering_display_metadata.h b/libavutil/mastering_display_metadata.h
> > index c23b07c..c1ba659 100644
> > --- a/libavutil/mastering_display_metadata.h
> > +++ b/libavutil/mastering_display_metadata.h
> > @@ -125,4 +125,49 @@ AVContentLightMetadata *av_content_light_metadata_alloc(size_t *size);
> > */
> > AVContentLightMetadata *av_content_light_metadata_create_side_data(AVFrame *frame);
> >
> > +/**
> > + * The characteristics of the nominal ambient viewing environment for
> > + * the display of the associated video content.
> > + * To be used as payload of a AVFrameSideData the appropriate type.
> > + *
> > + * @note The struct should be allocated with av_ambient_viewing_env_alloc()
> > + * and its size is not a part of the public ABI.
> > + */
> > +typedef struct AVAmbientViewingEnv {
> > + /**
> > + * specifies the environmental illuminance of the ambient viewing
> > + * environment in units of 0.0001 lux.
> > + * ambient_illuminance shall not be equal to 0.
> > + */
> > + uint32_t ambient_illuminance;
> > + /**
> > + * specify the normalized x and y chromaticity coordinates, respectively,
> > + * of the environmental ambient light in the nominal viewing environment,
> > + * according to the CIE 1931 definition of x and y as specified in ISO
> > + * 11664-1 (see also ISO 11664-3 and CIE 15), in normalized increments of
> > + * 0.00002. The values of ambient_light_x and ambient_light_y shall be in
> > + * the range of 0 to 50000
> > + */
> > + uint16_t ambient_light_x;
> > + uint16_t ambient_light_y;
> > +} AVAmbientViewingEnv;
> > +
> > +/**
> > + * Allocate an AVAmbientViewingEnv structure and set its fields to
> > + * default values. The resulting struct can be freed using av_freep().
> > + *
> > + * @return An AVAmbientViewingEnv filled with default values or NULL
> > + * on failure.
> > + */
> > +AVAmbientViewingEnv *av_ambient_viewing_env_alloc(size_t *size);
> > +
> > +/**
> > + * Allocate a complete AVAmbientViewingEnv and add it to the frame.
> > + *
> > + * @param frame The frame which side data is added to.
> > + *
> > + * @return The AVAmbientViewingEnv structure to be filled by caller.
> > + */
> > +AVAmbientViewingEnv *av_ambient_viewing_env_create_side_data(AVFrame *frame);
>
> All this boilerplate code for the various side-data--types makes me
> wonder whether they should not be replaced by something like
> void *av_frame_side_data_alloc(enum AVFrameSideDataType, size_t *size)
> and a corresponding av_frame_create_side_data(AVFrame *frame, enum
> AVFrameSideDataType).
It's good idea to have them? please add them anyway, I'll pending the patch
until it's ready to use.
> These functions would return an error in case it doesn't make sense to
> create a side data this way (because there is no struct associated to
> this side data type or because the size of this struct depends upon
> other parameters, too).
>
> > +
> > #endif /* AVUTIL_MASTERING_DISPLAY_METADATA_H */
> > diff --git a/libavutil/version.h b/libavutil/version.h
> > index 6735c20..998202f 100644
> > --- a/libavutil/version.h
> > +++ b/libavutil/version.h
> > @@ -79,7 +79,7 @@
> > */
> >
> > #define LIBAVUTIL_VERSION_MAJOR 57
> > -#define LIBAVUTIL_VERSION_MINOR 24
> > +#define LIBAVUTIL_VERSION_MINOR 25
> > #define LIBAVUTIL_VERSION_MICRO 101
>
> Micro needs to be reset when minor is bumped.
OK, forgot to reset it.
>
> >
> > #define LIBAVUTIL_VERSION_INT AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2022-04-05 23:11 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-27 23:25 [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
2022-03-27 23:25 ` [FFmpeg-devel] [PATCH 4/4] fftools/ffprobe: " lance.lmwang
2022-03-27 23:30 ` [FFmpeg-devel] [PATCH 1/4] avutil: add ambient viewing environment metadata side data James Almer
2022-03-28 1:28 ` lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 " lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 2/4] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
2022-03-28 14:30 ` Michael Niedermayer
2022-03-28 23:09 ` lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 3/4] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
2022-03-28 12:41 ` [FFmpeg-devel] [PATCH v2 4/4] fftools/ffprobe: " lance.lmwang
2022-04-05 6:40 ` [FFmpeg-devel] [PATCH v2 1/4] avutil: add ambient viewing environment metadata side data lance.lmwang
2022-04-05 9:13 ` Anton Khirnov
2022-04-05 9:24 ` lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 1/5] " lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 2/5] avcodec: add support for hevc ambient viewing environment SEI message lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 3/5] avfilter/vf_showinfo: add support for ambient viewing environment metadata lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 4/5] fftools/ffprobe: " lance.lmwang
2022-04-05 13:47 ` [FFmpeg-devel] [PATCH v3 5/5] avfilter/vf_showinfo: fix unknown side data type for DOVI_RPU_BUFFER lance.lmwang
2022-04-05 15:32 ` [FFmpeg-devel] [PATCH v3 1/5] avutil: add ambient viewing environment metadata side data Andreas Rheinhardt
2022-04-05 19:00 ` Lynne
2022-04-05 19:13 ` Anton Khirnov
2022-04-05 19:42 ` Andreas Rheinhardt
2022-04-05 23:11 ` lance.lmwang
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git