From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 2266142390
	for <ffmpegdev@gitmailbox.com>; Tue, 15 Mar 2022 08:47:34 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3D5E668B08A;
	Tue, 15 Mar 2022 10:47:32 +0200 (EET)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0731468AFC9
 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Mar 2022 10:47:25 +0200 (EET)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id AB2A1240179
 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Mar 2022 09:47:23 +0100 (CET)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id OJxOopvd4N2b for <ffmpeg-devel@ffmpeg.org>;
 Tue, 15 Mar 2022 09:47:22 +0100 (CET)
Received: from lain.red.khirnov.net (lain.red.khirnov.net
 [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.red.khirnov.net",
 Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 16A322400F5
 for <ffmpeg-devel@ffmpeg.org>; Tue, 15 Mar 2022 09:47:22 +0100 (CET)
Received: by lain.red.khirnov.net (Postfix, from userid 1000)
 id 2F9121601AD; Tue, 15 Mar 2022 09:47:22 +0100 (CET)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20220314115602.263642-1-onemda@gmail.com>
References: <20220314115602.263642-1-onemda@gmail.com>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Tue, 15 Mar 2022 09:47:22 +0100
Message-ID: <164733404216.19727.13997273471475705829@lain.red.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add null encoders
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/164733404216.19727.13997273471475705829@lain.red.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Paul B Mahol (2022-03-14 12:56:01)
> +static int null_encoder(AVCodecContext *avctx, AVPacket *pkt,
> +                        const AVFrame *frame, int *got_packet)
> +{
> +    int ret;
> +
> +    pkt->pts = frame->pts;
> +    if (avctx->codec_type == AVMEDIA_TYPE_AUDIO)
> +        pkt->duration = ff_samples_to_time_base(avctx, frame->nb_samples);
> +    pkt->flags |= AV_PKT_FLAG_KEY;
> +    if ((ret = ff_alloc_packet(avctx, pkt, 1)) < 0)
> +        return ret;
> +    *got_packet = 1;

Why return packets at all? Wouldn't it be simpler to just never return
any data?

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".