From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B85E54033D for ; Mon, 21 Feb 2022 11:22:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 975A168A2D7; Mon, 21 Feb 2022 13:22:23 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2A57A680545 for ; Mon, 21 Feb 2022 13:22:17 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 6AF4924017E; Mon, 21 Feb 2022 12:22:16 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id N8OFqe-SEoQ6; Mon, 21 Feb 2022 12:22:15 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D6B3E24017C; Mon, 21 Feb 2022 12:22:15 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 46E731601AD; Mon, 21 Feb 2022 12:22:16 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20220221082055.1526-1-Victoria.Zhislina@intel.com> References: <20220221082055.1526-1-Victoria.Zhislina@intel.com> Mail-Followup-To: FFmpeg development discussions and patches , Victoria Zhislina Date: Mon, 21 Feb 2022 12:22:16 +0100 Message-ID: <164544253625.19727.14104805163737761889@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Victoria Zhislina Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > libavfilter: zscale performance optimization >4x This reads like an advertisement rather than a useful description. It should say what the patch does, performance improvement numbers should be mentioned in the commit message body. Quoting Victoria Zhislina (2022-02-21 09:20:55) > By ffmpeg threading support implementation via frame slicing and doing > zimg_filter_graph_build that used to take 30-60% of each frame processig > only if necessary (some parameters changed) > the performance increase vs original version > in video downscale and color conversion >4x is seen > on 64 cores Intel Xeon, 3x on i7-6700K (4 cores with HT) This implies the patch does multiple unrelated things. Then it should be split in multiple patches, unless some important factor prevents that (then that factor should be described in the commit message). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".