From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Victoria Zhislina <Victoria.Zhislina@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: zscale performance optimization >4x
Date: Mon, 21 Feb 2022 12:22:16 +0100
Message-ID: <164544253625.19727.14104805163737761889@lain.red.khirnov.net> (raw)
In-Reply-To: <20220221082055.1526-1-Victoria.Zhislina@intel.com>
> libavfilter: zscale performance optimization >4x
This reads like an advertisement rather than a useful description. It
should say what the patch does, performance improvement numbers should
be mentioned in the commit message body.
Quoting Victoria Zhislina (2022-02-21 09:20:55)
> By ffmpeg threading support implementation via frame slicing and doing
> zimg_filter_graph_build that used to take 30-60% of each frame processig
> only if necessary (some parameters changed)
> the performance increase vs original version
> in video downscale and color conversion >4x is seen
> on 64 cores Intel Xeon, 3x on i7-6700K (4 cores with HT)
This implies the patch does multiple unrelated things. Then it should be
split in multiple patches, unless some important factor prevents that
(then that factor should be described in the commit message).
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-21 11:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 8:20 Victoria Zhislina
2022-02-21 11:22 ` Anton Khirnov [this message]
2022-02-21 15:22 ` Victoria Zhislina
-- strict thread matches above, loose matches on Subject: below --
2022-02-19 13:58 Victoria Zhislina
2022-02-20 18:51 ` Paul B Mahol
2022-02-22 5:25 ` Lynne
2022-02-22 8:15 ` Paul B Mahol
2022-02-22 8:16 ` Paul B Mahol
2022-02-22 9:34 ` Victoria Zhislina
2022-03-10 18:41 ` Victoria Zhislina
2022-03-10 18:47 ` Paul B Mahol
2022-03-11 16:42 ` Victoria Zhislina
2022-02-18 15:24 Victoria Zhislina
2022-02-18 15:48 ` James Almer
2022-02-18 16:00 ` Paul B Mahol
2022-02-10 10:08 Victoria Zhislina
2022-02-18 11:43 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164544253625.19727.14104805163737761889@lain.red.khirnov.net \
--to=anton@khirnov.net \
--cc=Victoria.Zhislina@intel.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git