Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix alignment requirements for audio and video filters
Date: Mon, 21 Feb 2022 12:07:52 +0100
Message-ID: <164544167241.19727.2074552888266890134@lain.red.khirnov.net> (raw)
In-Reply-To: <20220220180747.291489-1-onemda@gmail.com>

Quoting Paul B Mahol (2022-02-20 19:07:47)
> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
> index aab408d355..aaf1642b4f 100644
> --- a/libavfilter/framepool.c
> +++ b/libavfilter/framepool.c
> @@ -76,15 +76,13 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size),
>      }
>  
>      if (!pool->linesize[0]) {
> -        for(i = 1; i <= align; i += i) {
> -            ret = av_image_fill_linesizes(pool->linesize, pool->format,
> -                                          FFALIGN(pool->width, i));
> -            if (ret < 0) {
> -                goto fail;
> -            }
> -            if (!(pool->linesize[0] & (pool->align - 1)))
> -                break;
> +        ret = av_image_fill_linesizes(pool->linesize, pool->format,
> +                                      FFALIGN(pool->width, align));
> +        if (ret < 0) {
> +            goto fail;
>          }
> +        if ((pool->linesize[0] & (pool->align - 1)))

Check all of them, not just the first one.

Otherwise looks good.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".