From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: fix adjustment that can crash filtering
Date: Sun, 20 Feb 2022 17:15:02 +0100
Message-ID: <164537370230.19727.16075366139142898549@lain.red.khirnov.net> (raw)
In-Reply-To: <20220218104605.105011-1-onemda@gmail.com>
Quoting Paul B Mahol (2022-02-18 11:46:05)
> Fixes #9551.
>
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
> libavfilter/framepool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
> index 7c63807df3..aab408d355 100644
> --- a/libavfilter/framepool.c
> +++ b/libavfilter/framepool.c
> @@ -96,7 +96,7 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size),
> if (i == 1 || i == 2)
> h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h);
>
> - pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + 16 + 16 - 1,
> + pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + 16 + 16 - 0,
> alloc);
all these magic constants are extremely non-obvious, why are they there
and why does removing that 1 crash anything?
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-20 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 10:46 Paul B Mahol
2022-02-20 16:15 ` Anton Khirnov [this message]
2022-02-20 17:03 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164537370230.19727.16075366139142898549@lain.red.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git