[FFmpeg-devel] Request: make framepool visible externally

[FFmpeg-devel] Request: make framepool visible externally

[Marco Vianini]

Hi all
I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc.

To improve performances I'd like to use framepool.
So I need to include "libavfilter/framepool.h", but I cannot, because this file is not exported. 
Should be possible to add "framepool.h" to HEADERS in "libavfilter\Makefile" ?
Code:"NAME = avfilterDESC = FFmpeg audio/video filtering library
HEADERS = avfilter.h                                                    \          buffersink.h                                                  \          buffersrc.h                                                   \          version.h                                                     \   framepool.h                                                   \   ...   "   
Thank YouMarco Vianini
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request: make framepool visible externally

[Timo Rothenpieler]

On 12.07.2022 18:28, Marco Vianini wrote:
> Hi all
> I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc.

That is a really old version, and you should desperately update.

> To improve performances I'd like to use framepool.
> So I need to include "libavfilter/framepool.h", but I cannot, because this file is not exported.
> Should be possible to add "framepool.h" to HEADERS in "libavfilter\Makefile" ?
> Code:"NAME = avfilterDESC = FFmpeg audio/video filtering library
> HEADERS = avfilter.h                                                    \          buffersink.h                                                  \          buffersrc.h                                                   \          version.h                                                     \   framepool.h                

framepool.h is not a public header, and contains no publicly exported 
functions.
Even if you got the header, you couldn't use the functions since they're 
not exported from the library.

So no, you can't use any of the stuff in there outside of libavfilter.
It's also not in any way stable, so can break its API at any random point.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request: make framepool visible externally

[Marco Vianini]

Yes, I know the version 4.1.6 is very old. But I stuck in 4.1.x versions because I need NDI support.
In the file "framepool.h" there are only some very high level functions to deal with AVFrame pool:
"FFFramePool *ff_frame_pool_video_init(...);FFFramePool *ff_frame_pool_audio_init(...);void ff_frame_pool_uninit(FFFramePool **pool);int ff_frame_pool_get_video_config();int ff_frame_pool_get_audio_config();AVFrame *ff_frame_pool_get(FFFramePool *pool);"
In my debug tests I tried to make "framepool.h" public and to use it, and it worked like a charm!With an important improvement on performances (like a pool does).
Probably I don't understand what You mean with "It's also not in any way stable, so can break its API at any random point.".Can You please clarify?
I think that it is very stable, and contains only high level functions (see above).Then my request to make it public.
Thank You
Il martedì 12 luglio 2022 19:16:02 CEST, Timo Rothenpieler <timo@rothenpieler.org> ha scritto:
 
 
 On 12.07.2022 18:28, Marco Vianini wrote:
> Hi all
> I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc.

That is a really old version, and you should desperately update.

> To improve performances I'd like to use framepool.
> So I need to include "libavfilter/framepool.h", but I cannot, because this file is not exported.
> Should be possible to add "framepool.h" to HEADERS in "libavfilter\Makefile" ?
> Code:"NAME = avfilterDESC = FFmpeg audio/video filtering library
> HEADERS = avfilter.h                                                    \          buffersink.h                                                  \          buffersrc.h                                                   \          version.h                                                     \   framepool.h                

framepool.h is not a public header, and contains no publicly exported 
functions.
Even if you got the header, you couldn't use the functions since they're 
not exported from the library.

So no, you can't use any of the stuff in there outside of libavfilter.
It's also not in any way stable, so can break its API at any random point.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
  
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request: make framepool visible externally

[James Almer]

On 7/12/2022 1:28 PM, Marco Vianini wrote:
> Hi all
> I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc.
> 
> To improve performances I'd like to use framepool.
> So I need to include "libavfilter/framepool.h", but I cannot, because this file is not exported.
> Should be possible to add "framepool.h" to HEADERS in "libavfilter\Makefile" ?
> Code:"NAME = avfilterDESC = FFmpeg audio/video filtering library
> HEADERS = avfilter.h                                                    \          buffersink.h                                                  \          buffersrc.h                                                   \          version.h                                                     \   framepool.h                                                   \   ...   "
> Thank YouMarco Vianini

What you want is to use the bufferpool API in libavutil for your frames.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request: make framepool visible externally

[Marco Vianini]

 Actually I was speaking about framepool, and not bufferpool.
framepool is intended to get an "AVFrame *" from a pool, by "ff_frame_pool_get".
At the moment it is available only internally to "libavfilter".
It permits an important improvement on performances, by using a pool. So it should be very nice if I could use it in my own code.
To be possible framepool.h should become a public header.
Thank You

    Il martedì 12 luglio 2022 19:19:34 CEST, James Almer <jamrial@gmail.com> ha scritto:  
 
 On 7/12/2022 1:28 PM, Marco Vianini wrote:
> Hi all
> I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc.
> 
> To improve performances I'd like to use framepool.
> So I need to include "libavfilter/framepool.h", but I cannot, because this file is not exported.
> Should be possible to add "framepool.h" to HEADERS in "libavfilter\Makefile" ?
> Code:"NAME = avfilterDESC = FFmpeg audio/video filtering library
> HEADERS = avfilter.h                                                    \          buffersink.h                                                  \          buffersrc.h                                                   \          version.h                                                     \   framepool.h                                                   \   ...   "
> Thank YouMarco Vianini

What you want is to use the bufferpool API in libavutil for your frames.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
  
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request: make framepool visible externally

[James Almer]

On 7/13/2022 5:03 AM, Marco Vianini wrote:
>   Actually I was speaking about framepool, and not bufferpool.
> framepool is intended to get an "AVFrame *" from a pool, by "ff_frame_pool_get".
> At the moment it is available only internally to "libavfilter".
> It permits an important improvement on performances, by using a pool. So it should be very nice if I could use it in my own code.
> To be possible framepool.h should become a public header.
> Thank You

Please, do not top post in this list.

I know you want AVFrames. What i mean is that you should use the 
existing buffer pool API to achieve that. Write your own function that 
returns a freshly allocated AVFrame that fills the buf[] and data[] 
fields with buffers returned by av_buffer_pool_get() instead of 
av_buffer_alloc().
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Request: make framepool visible externally

[Marco Vianini]

On Wednesday, July 13, 2022 at 02:02:18 PM GMT+2, James Almer <jamrial@gmail.com> wrote: 





On 7/13/2022 5:03 AM, Marco Vianini wrote:
>  Actually I was speaking about framepool, and not bufferpool.
> framepool is intended to get an "AVFrame *" from a pool, by "ff_frame_pool_get".
> At the moment it is available only internally to "libavfilter".
> It permits an important improvement on performances, by using a pool. So it should be very nice if I could use it in my own code.
> To be possible framepool.h should become a public header.
> Thank You

Please, do not top post in this list.

I know you want AVFrames. What i mean is that you should use the 
existing buffer pool API to achieve that. Write your own function that 
returns a freshly allocated AVFrame that fills the buf[] and data[] 
fields with buffers returned by av_buffer_pool_get() instead of 
av_buffer_alloc().

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".


Sorry, I misunderstood what you mean with previous answer.
However Yes, surely I can write my own code (replicating what already done by framepool).
Thank You
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".