Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Schneider <asn@cryptomilk.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/gnutls: Use the systems default crypto policy
Date: Mon, 14 Feb 2022 17:07:48 +0100
Message-ID: <164485486839.9519.7985645280233928703@lain.red.khirnov.net> (raw)
In-Reply-To: <20220211073414.449304-1-asn@cryptomilk.org>

Quoting Andreas Schneider (2022-02-11 08:34:14)
> We should use the systems crypto policy by default. If there is no
> system policy, gnutls will use the "NORMAL" policy.
> 
> Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
> ---
>  libavformat/tls_gnutls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/tls_gnutls.c b/libavformat/tls_gnutls.c
> index 741578a596..2ab38a199b 100644
> --- a/libavformat/tls_gnutls.c
> +++ b/libavformat/tls_gnutls.c
> @@ -192,7 +192,7 @@ static int tls_open(URLContext *h, const char *uri, int flags, AVDictionary **op
>      gnutls_transport_set_pull_function(p->session, gnutls_url_pull);
>      gnutls_transport_set_push_function(p->session, gnutls_url_push);
>      gnutls_transport_set_ptr(p->session, p);
> -    gnutls_priority_set_direct(p->session, "NORMAL", NULL);
> +    gnutls_set_default_priority(p->session);
>      do {
>          if (ff_check_interrupt(&h->interrupt_callback)) {
>              ret = AVERROR_EXIT;

Looks reasonable, will push tomorrow if nobody objects.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-02-14 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  7:34 Andreas Schneider
2022-02-14 16:07 ` Anton Khirnov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164485486839.9519.7985645280233928703@lain.red.khirnov.net \
    --to=anton@khirnov.net \
    --cc=asn@cryptomilk.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git