From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 14C6B40DB5 for ; Tue, 8 Feb 2022 09:37:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7CE1868B1F1; Tue, 8 Feb 2022 11:37:00 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CFC8368B0D7 for ; Tue, 8 Feb 2022 11:36:54 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 0CC6A240179 for ; Tue, 8 Feb 2022 10:36:54 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id cat6O7ER7Ybo for ; Tue, 8 Feb 2022 10:36:53 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id F12CA240175 for ; Tue, 8 Feb 2022 10:36:52 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 3B7571601AD; Tue, 8 Feb 2022 10:36:53 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: =?utf-8?q?=3CDM8P223MB03652A19235F0878A58FEC2DBA2C9=40DM8P223MB?= =?utf-8?q?0365=2ENAMP223=2EPROD=2EOUTLOOK=2ECOM=3E?= References: <20220201100227.18928-1-anton@khirnov.net> =?utf-8?q?=3CAM7PR03M?= =?utf-8?q?B6660368FF770BF9CFF25DFB38F2C9=40AM7PR03MB6660=2Eeurprd03=2Eprod?= =?utf-8?q?=2Eoutlook=2Ecom=3E?= =?utf-8?q?=3CDM8P223MB0365?= =?utf-8?q?2A19235F0878A58FEC2DBA2C9=40DM8P223MB0365=2ENAMP223=2EPROD=2EOUTL?= =?utf-8?q?OOK=2ECOM=3E?= Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 08 Feb 2022 10:36:53 +0100 Message-ID: <164431301321.19727.453011583235613178@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavc/mpeg*: drop the XvMC hwaccel code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Soft Works (2022-02-07 03:18:54) > I sometimes wonder whether there exists a single API user who > really understands this (very special) kind of logic and > would make decisions based on that understanding. > > When it's not even fully understood internally, how should it > be understood externally? The rule for API users is simple: you are not allowed to assume a specific component (like a decoder, demuxer or hwaccel) will be available at runtime*. You are supposed to check for it using the APIs provided for this purpose. In this case, AV_PIX_FMT_XVMC will just stop being offered in get_format(). Not to mention that I very much doubt there are any users of xvmc left, besides the original mplayer. * unless you are running with a very specific verified build, in which case a removal like this should be caught at the build stage -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".