From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE416407E8 for ; Mon, 31 Jan 2022 13:27:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 08B2B68B277; Mon, 31 Jan 2022 15:27:50 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7654168B22B for ; Mon, 31 Jan 2022 15:27:43 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EDC7C24017C for ; Mon, 31 Jan 2022 14:27:42 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id K5kamD3-2eN8 for ; Mon, 31 Jan 2022 14:27:42 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 6F25B240179 for ; Mon, 31 Jan 2022 14:27:42 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 66D421601AD; Mon, 31 Jan 2022 14:27:38 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20220124204656.48625-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 31 Jan 2022 14:27:38 +0100 Message-ID: <164363565831.23111.2139997009459012752@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2022-01-27 16:08:10) > > + * be checked) > > + * > > + * No new fields may be added to it without a major version bump, except for > > + * new elements of the union fitting in sizeof(uint64_t). > > + */ > > +typedef struct AVChannelLayout { > > + /** > > + * Channel order used in this layout. > > + * This is a mandatory field. > > + */ > > + enum AVChannelOrder order; > > + > > + /** > > + * Number of channels in this layout. Mandatory field. > > + */ > > > + int nb_channels; > > If it does not make sense to have a negative value, then unsigned is > preferable. We discussed this already a year ago or so. IIRC the conclusion was that channels counts are signed everywhere and making this one unsigned adds a danger of unexpected conversions. > I would really like you to consider the option of refcounting. I think > it would be more convenient and more robust for the future. I considered refcounting back in 2013 when I wrote the original version of this API and decided against; I still stand by that decision. But I assure you this option was considered. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".