From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1AE9E407D3 for ; Mon, 31 Jan 2022 11:53:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 151E968B24E; Mon, 31 Jan 2022 13:53:47 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E249B68AEBC for ; Mon, 31 Jan 2022 13:53:40 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 124A924017C for ; Mon, 31 Jan 2022 12:53:40 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id FJaXEMpn569F for ; Mon, 31 Jan 2022 12:53:39 +0100 (CET) Received: from lain.red.khirnov.net (lain.red.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.red.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 766D0240179 for ; Mon, 31 Jan 2022 12:53:39 +0100 (CET) Received: by lain.red.khirnov.net (Postfix, from userid 1000) id 95F261601AD; Mon, 31 Jan 2022 12:53:39 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20210115045832.76405-1-borbarak@fb.com> =?utf-8?q?=3CMN2PR15MB2?= =?utf-8?q?605F2669A411F794B6C2B40B5A70=40MN2PR15MB2605=2Enamprd15=2Eprod=2E?= =?utf-8?q?outlook=2Ecom=3E_=3CMR3WgJJ--3-2=40lynne=2Eee=3E_=3CMN2PR15MB2605?= =?utf-8?q?997AC36969E5639782C4B5A30=40MN2PR15MB2605=2Enamprd15=2Eprod=2Eout?= =?utf-8?q?look=2Ecom=3E?= <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 31 Jan 2022 12:53:39 +0100 Message-ID: <164363001951.23111.4989616914372511566@lain.red.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Thilo Borgmann (2022-01-18 14:58:07) > >> Violations of code style. > > Enhanced. Not enough. There are still many remaining, e.g. * opening brace of a function definition should be on its own line * the context should generally be the first argument * unsigned char* should be uint8_t* * mixed declarations and code (the compiler should warn about that) * pointless casts all over the place > +typedef struct SiTiContext { > + const AVClass *class; > + int pixel_depth; > + int width, height; > + int nb_frames; uint64_t > +static int config_input(AVFilterLink *inlink) { > + // Video input data avilable > + AVFilterContext *ctx = inlink->dst; > + SiTiContext *s = ctx->priv; > + int max_pixsteps[4]; > + > + const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(inlink->format); > + av_image_fill_max_pixsteps(max_pixsteps, NULL, desc); > + > + s->pixel_depth = max_pixsteps[0]; > + s->width = inlink->w; > + s->height = inlink->h; > + size_t pixel_sz = s->pixel_depth==1 ? (size_t) sizeof(uint8_t) : (size_t) sizeof(uint16_t); > + size_t data_sz = (size_t) s->width * pixel_sz * s->height; > + s->prev_frame = av_malloc(data_sz); unchecked malloc > + > + return 0; > +} > + > +// Get frame data handling 8 and 10 bit formats > +static uint16_t get_frame_data(const unsigned char* src, int pixel_depth, int index) { > + const uint16_t *src16 = (const uint16_t *)src; > + if (pixel_depth == 2) > + return src16[index]; > + return (uint16_t) src[index]; > +} going through this branch nine times for every single pixel is just atrocious templatize convolve_sobel()/calculate_motion() for 8/16 bits > +static int filter_frame(AVFilterLink *inlink, AVFrame *frame) { > + AVFilterContext *ctx = inlink->dst; > + SiTiContext *s = ctx->priv; > + > + // Gradient matrix will not include the input frame's edges > + size_t gradient_data_sz = (size_t) (s->width - 2) * sizeof(double) * (s->height - 2); > + double *gradient_matrix = av_malloc(gradient_data_sz); > + size_t motion_data_sz = (size_t) s->width * sizeof(double) * s->height; > + double *motion_matrix = av_malloc(motion_data_sz); These have a fixed size that is known at config_input() time, no point in allocating them anew for each frame. Also, I don't see where motion_matrix is freed. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".